Merged
Conversation
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
lorux0
added
force-build
lorux0
added
force-build
This reverts commit d6e3c5e.
lorux0
added
force-build
lorux0
added
force-build
lorux0
added
force-build
lorux0
added
force-build
github-actions
Bot
requested review from
Ludmilafantaniella,
mikhail-dcl and
popuz
# Conflicts: # Explorer/Assets/DCL/Infrastructure/Global/AppArgs/AppArgsFlags.cs
lorux0
added
clean-build
davidejensen
approved these changes
Feb 4, 2026
Ludmilafantaniella
approved these changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
✅ QA Verified on Windows and macOS.
- Opening the client multiple times without parameters correctly triggers the single-instance restriction.
- On macOS, clicking the app again redirects to the already running instance (expected behavior).
- When launching a second instance via terminal without --multi-instance, the exit modal is shown as expected.
- Launching with --multi-instance allows running multiple instances correctly on both platforms.
⚠️ Couldn't check Creator Hub because it's an issue pending on the creator-hub team.
Behavior matches the expected flow described in the PR. Good to merge 🚀
Windows Evidence:
6923-evi.mp4
MacOs Evidence
mac.mp4
Collaborator
Author
|
This PR must be merged after this task is done: decentraland/creator-hub#1092 |
# Conflicts: # Explorer/Assets/DCL/Infrastructure/Global/AppArgs/AppArgsFlags.cs # Explorer/Assets/DCL/Infrastructure/Global/Dynamic/MainSceneLoader.cs # Explorer/Assets/Scenes/Main.unity
Ludmilafantaniella
approved these changes
Mar 4, 2026
Contributor
Ludmilafantaniella
left a comment
Ludmilafantaniella
left a comment
There was a problem hiding this comment.
✅ Verified on Windows and Mac
QA validation performed:
- Opened the client multiple times → second instance is blocked with popup
- Verified only exit option is available (no parallel launch)
- Launched with
--multi-instance→ multiple instances run correctly - Confirmed Mac flow using
open -n Decentraland.app --args --multi-instance
Fixes:
- ✅ #6266 – Multiple client instances now restricted for regular users
- ✅ #5202 – Preview instances now allow independent logins and proper multiplayer visibility
Creator Hub PR #1187 – Multi-instance Support
QA validation performed:
- Multi-instance toggle only visible for scenes with
@dcl/sdk >= 7.20.4 - Toggle hidden for older SDK versions
--multi-instanceflag correctly passed/omitted- No CLI errors when switching between supported/unsupported scenes
- Confirmed toggle is only present in Preview Options (not App Settings)
No regressions detected across normal client or preview flows.
Status: Approved for merge 🚀
EXPLORER EVIDENCE:
MultipleInstances-Explorer.mp4
mac-multi-instance.mp4
CREATOR HUB EVIDENCE":
Ch-multiinstances.mp4
CH.mp4
LOCAL SCENES:
localScene.mp4
✅Smoke Test:
- ✔️ Log In/Log Out
- ✔️ Backpack and wearables in world
- ✔️ Emotes in world and in backpack
- ✔️ Teleport with map/coordinates/Jump In
- ✔️ Chat and multiplayer
- ✔️ Profile card
- ✔️ Camera
- ✔️ Skybox
- ✔️ Settings
Contributor
# Conflicts: # Explorer/Assets/DCL/Infrastructure/Global/AppArgs/AppArgsFlags.cs
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Fixes #6266
Implements a
instance.lockfile that allows to check if there are multiple instances running in the machine. You are only allowed to run multiple instances if the arg is passed--multi-instance.Test Instructions
Open the client multiple times. A new popup should be shown allowing you to exit the application only.
Open the client with
--multi-instanceparam. Check that you can run it multiple times.NOTE: on mac you might have to run it with
open -n Decentraland.app --args --multi-instanceto run it multiple times.Additionally from the creator hub or running a local scene, you should be able to run multiple instances if you want (for multiplayer purposes).
How to test from the Creator Hub:
~/Library/Application Support/DecentralandLauncherLight/v0.xxx.0-alpha/Decentraland.app) by the build generated from this PRHow to test running a local scene :
npm run start --multi-instanceQuality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.