feat: window mode and resolution improvements#7102
Merged
m3taphysics merged 15 commits intodevfrom Mar 24, 2026
Merged
Conversation
Contributor
8df4a21 to
413f20d
Compare
…tion_improvements
…tion_improvements
…tion_improvements
DafGreco
approved these changes
Mar 20, 2026
DafGreco
left a comment
There was a problem hiding this comment.
✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path
Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:
- [✔️ ] Backpack and wearables in world
- [✔️ ] Emotes in world and in backpack
- [✔️ ] Teleport with map/coordinates/Jump In
- [✔️ ] Chat and multiplayer
- [✔️ ] Settings
Evidence:
Screen.Recording.2026-03-20.at.11.05.28.mov
20260320-1106-22.4125018.mp4
alejandro-jimenez-dcl
requested changes
Mar 20, 2026
Contributor
alejandro-jimenez-dcl
left a comment
There was a problem hiding this comment.
Good work! Left some small requests.
On a side note, why do we need a native plugin? Can we have that rationale written down either in the ticket or this PR?
alejandro-jimenez-dcl
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR changes how we handle / manage resolutions and window mode. Notably:
What does this PR change?
All of the resolution / window management logic has been refactored / unified in NativeWindowManager, which now handles resolution changes, full screen toggling, and requesting / releasing a temporary window mode (e.g. on authentication).
The NativeWindowManager with Mac / Win native plugins is required because there are no ways to restrict aspect ration or min / max resolution with just the Unity API. Continuously checking Screen.width / Screen.height and forcing it to a specific aspect ration / size does not give good results (extremely jittery).
Test Instructions
Test switching between fullscreen and windowed mode, and resizing the window. which should stay between the min / max aspect ratios, and should not be able to be scaled bellow the minimum size.
Verify that when we request a temporary window mode (for example when in full screen mode, and authentication is requested), Explorer correctly switches to window mode and then back.
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.