Skip to content

Trigger a performance test when a PR build completes#7229

Merged
m3taphysics merged 7 commits intodevfrom
feat/pr-comment-perf-test
Mar 3, 2026
Merged

Trigger a performance test when a PR build completes#7229
m3taphysics merged 7 commits intodevfrom
feat/pr-comment-perf-test

Conversation

@AnsisMalins
Copy link
Copy Markdown
Contributor

@AnsisMalins AnsisMalins commented Feb 24, 2026

Pull Request Description

What does this PR change?

This change adds an action to the PR build workflow to trigger a performance test when the build completes. This is a change to the build workflow, not to the game itself.

Test Instructions

There's no build to test.

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@charly-bg
Copy link
Copy Markdown
Contributor

LGTM

@AnsisMalins AnsisMalins marked this pull request as ready for review February 25, 2026 13:09
@AnsisMalins AnsisMalins requested review from a team as code owners February 25, 2026 13:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 25, 2026

badge

Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit 9d8b19b
Logs https://github.com/decentraland/unity-explorer/actions/runs/22478205722
Download Windows https://github.com/decentraland/unity-explorer/suites/58772301799/artifacts/5687035984
Download Windows S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/feat/pr-comment-perf-test/pr-19189-9d8b19b/Decentraland_windows64.zip
Download Mac https://github.com/decentraland/unity-explorer/suites/58772301799/artifacts/5687061528
Download Mac S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/feat/pr-comment-perf-test/pr-19189-9d8b19b/Decentraland_macos.zip
Built on 2026-02-27T08:44:44Z

Artifact size check

Target Size (MB / MiB) Cap (MB) Δ MB vs release Δ % vs release Result
windows64 317.4 / 302.7 320 0 -0.19% ✅ OK
macos 405.2 / 386.5 410 -1 -0.44% ✅ OK

Comparing against: v0.129.0-alpha

@AnsisMalins AnsisMalins added the force-build Used to trigger a build on draft PR label Feb 25, 2026
@AnsisMalins
Copy link
Copy Markdown
Contributor Author

Bing bong!

@AnsisMalins
Copy link
Copy Markdown
Contributor Author

Intel Core i3

Change samples: 933
Baseline samples: 896

Metric Change Baseline Delta Improvement
CPU average 64.1 ms 66.8 ms -2.7 ms 4.0% 🟢
CPU 1% worst 160.2 ms 186.4 ms -26.2 ms 14.0% 🟢
CPU 0.1% worst 296.5 ms 425.9 ms -129.4 ms 30.4% 🟢
GPU average 49.9 ms 51.8 ms -1.9 ms 3.7% 🟢
GPU 1% worst 64.6 ms 73.3 ms -8.7 ms 11.8% 🟢
GPU 0.1% worst 68.9 ms 96.0 ms -27.0 ms 28.2% 🟢

@AnsisMalins
Copy link
Copy Markdown
Contributor Author

It's working! 🎉

@AnsisMalins AnsisMalins removed do not merge force-build Used to trigger a build on draft PR labels Feb 27, 2026
@AnsisMalins
Copy link
Copy Markdown
Contributor Author

Workflow test

PR number: (https://github.com/decentraland/unity-explorer/pull/7229)[7229]
Windows change build
Windows baseline build
macOS change build
macOS baseline build

Intel Core i3

Change samples: 927
Baseline samples: 929

Metric Change Baseline Delta Improvement
CPU average 64.5 ms 64.5 ms 0.1 ms -0.1% 🔴
CPU 1% worst 154.8 ms 168.6 ms -13.9 ms 8.2% 🟢
CPU 0.1% worst 306.3 ms 312.5 ms -6.2 ms 2.0% 🔴
GPU average 46.7 ms 46.4 ms 0.3 ms -0.5% 🔴
GPU 1% worst 58.4 ms 58.0 ms 0.4 ms -0.7% 🔴
GPU 0.1% worst 66.4 ms 60.9 ms 5.5 ms -9.0% 🔴

@AnsisMalins
Copy link
Copy Markdown
Contributor Author

Workflow test

PR number: 7229
Windows change build
Windows baseline build
macOS change build
macOS baseline build

Intel Core i3

Change samples: 1226
Baseline samples: 1236

Metric Change Baseline Delta Improvement
CPU average 48.8 ms 48.4 ms 0.4 ms -0.8% 🔴
CPU 1% worst 91.0 ms 88.5 ms 2.5 ms -2.9% 🔴
CPU 0.1% worst 148.2 ms 175.5 ms -27.3 ms 15.5% 🟢
GPU average 40.3 ms 40.5 ms -0.2 ms 0.4% 🔴
GPU 1% worst 46.9 ms 47.7 ms -0.8 ms 1.6% 🔴
GPU 0.1% worst 49.1 ms 51.0 ms -1.9 ms 3.8% 🟢

Comment thread .github/workflows/pr-comment-artifact-url.yml Outdated
Comment thread .github/workflows/pr-comment-artifact-url.yml Outdated
Copy link
Copy Markdown
Contributor

@charly-bg charly-bg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m3taphysics m3taphysics merged commit 5f9e4d5 into dev Mar 3, 2026
3 of 6 checks passed
@m3taphysics m3taphysics deleted the feat/pr-comment-perf-test branch March 3, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants