Skip to content

feat(vm): support live change of cpu fractions #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
diafour wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat(vm): support live change of cpu fractions #2210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df19871
feat(vm): support live change of cpu fractions
diafour Apr 13, 2026
dbbee47
++ delay before "cleanup done"
diafour Apr 13, 2026
2e20c96
++ sleep before secret annotation
diafour Apr 13, 2026
79071ef
++ add delay for testing
diafour Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions images/dvcr-artifact/cmd/dvcr-cleaner/cmd/gc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,14 @@ func autoCleanupHandler(cmd *cobra.Command, args []string) error {
errs = multierror.Append(errs, cleanupErr)
}

// Testing: sleep and print errors if present.
time.Sleep(time.Second * 30)
err = errs.ErrorOrNil()
if err != nil {
fmt.Printf("Error while cleaning up stale images after cleanup: %v\n", err)
}
// Testing end.

result := map[string]any{
"result": "success",
"startedAt": started,
Expand Down
5 changes: 4 additions & 1 deletion images/virtualization-artifact/pkg/controller/dvcr-garbage-collection/internal/life_cycle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@ func (h LifeCycleHandler) Handle(ctx context.Context, req reconcile.Request, dep
// Put full result JSON into annotation on deployment.
annotations.AddAnnotation(deploy, annotations.AnnDVCRGarbageCollectionResult, h.dvcrService.GetGarbageCollectionResult(secret))
// It is now possible to delete a secret.
return reconcile.Result{}, h.dvcrService.DeleteGarbageCollectionSecret(ctx)
// Test: add delay to catch race condition delete secret -> hook change values -> helm apply new version of deploy/dvcr.
err = h.dvcrService.DeleteGarbageCollectionSecret(ctx)
time.Sleep(time.Second * 10)
return reconcile.Result{}, err
}

if h.dvcrService.IsGarbageCollectionStarted(secret) {
Expand Down
Loading