Open
Conversation
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement automatic cleanup of stale
NodeUSBDeviceobjects when the USB device is no longer present on the host and the object is not assigned to any namespace.The deletion flow was moved to the lifecycle handler logic:
FinalizerNodeUSBDeviceCleanupfirst;NodeUSBDevicefor deletion;USBDevicecleanup only in the standard deletion path afterdeletionTimestampis set.Why do we need it, and what problem does it solve?
A detached or disappeared USB device could leave behind an unassigned
NodeUSBDevicewithReady=FalseandReason=NotFound.Such objects are stale and should be removed automatically, but the cleanup must still respect the Kubernetes finalizer flow to avoid deleting the parent object before owned
USBDeviceresources are cleaned up.This change makes the behavior safe and deterministic:
NodeUSBDeviceobjects are removed automatically;USBDeviceobjects are cleaned through the normal finalizer-based deletion lifecycle;What is the expected result?
NodeUSBDevicegetsReady=FalsewithReason=NotFound.NodeUSBDevice.deletionTimestampis set, the controller removes ownedUSBDeviceresources and then removes the finalizer.NodeUSBDeviceis deleted automatically.Checklist
Changelog entries