feat(nodeusbdevice): mirror usb attached condition#2221
Open
feat(nodeusbdevice): mirror usb attached condition#2221
Conversation
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the
Attachedcondition toNodeUSBDeviceand mirror it fromUSBDevice.status.conditions[type=Attached].The change also adds an
Attachedprinter column forNodeUSBDevice, updates the controller to reconcile this condition, and adds a watcher soNodeUSBDeviceis refreshed when the correspondingUSBDevicechanges.Why do we need it, and what problem does it solve?
NodeUSBDevicecurrently exposes onlyReadyandAssignedconditions, so it is not possible to tell from this resource whether the device is currently attached to a virtual machine.The actual attachment state already exists in
USBDevice, but it is inconvenient for cluster-level device visibility becauseNodeUSBDeviceis the cluster-scoped source operators look at first.This change makes
NodeUSBDevicereflect the existing attachment state without introducing a second source of truth. The controller simply mirrorsUSBDevice.Attachedstatus, reason, and message intoNodeUSBDevice.Attached.What is the expected result?
NodeUSBDeviceto a namespace.kubectl get nodeusbdevicesshowsAttached=False.USBDeviceto aVirtualMachine.NodeUSBDevice.status.conditions[type=Attached]becomesTrueand theAttachedprinter column is updated.NodeUSBDevicemirrors the correspondingUSBDevice.Attachedstate and reason.Checklist
Changelog entries