Security fix: prevent path traversal in SendOauth2 #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two path traversal vulnerabilities identified recently.
Issue 1: mailAuthSet path traversal
mailAuthSet was previously passed directly into SendOauth2B and SendOauth2D and later used in filesystem operations.
This allowed directory traversal (e.g. ../) and arbitrary file read/write.
Fix:
Issue 2: gmailXoauth2Credentials file write traversal
gmailXoauth2Credentials was used directly as a filename in file_put_contents(), allowing arbitrary file overwrite.
Fix:
Verification
These fixes apply validation at the core classes so all wrappers are protected consistently.