Open
Conversation
davecgh
force-pushed
the
peer_context_lifecycle
branch
2 times, most recently
from
858a00e to
d084cc9
Compare
jholdstock
approved these changes
Mar 9, 2026
davecgh
force-pushed
the
peer_context_lifecycle
branch
5 times, most recently
from
be31954 to
fff233c
Compare
jholdstock
approved these changes
Mar 10, 2026
davecgh
force-pushed
the
peer_context_lifecycle
branch
2 times, most recently
from
e3b8d67 to
67005e3
Compare
This modifies the lifecycle of peers to use the more modern Run pattern that based on contexts. In particular, this replaces the Start and WaitForDisconnect methods with a single method named Run and arranges for it to block until the provided context is cancelled or the peer is disconnected. This is more flexible for the caller since it can easily turn blocking code into async code while the reverse is not true. The new Run method waits for all goroutines that it starts to shutdown before returning to help ensure an orderly shutdown. Since all exported methods that send messages to the various groroutines via channels already select across the quit channel which is closed when the peer disconnects, the peer is now forcibly disconnected when the context is cancelled. This approach allows the flexibility for callers to use any combination of manually disconnecting peers via the Disconnect method and allowing them to automatically be disconnected when the context is cancelled. It also updates the server code accordingly.
davecgh
force-pushed
the
peer_context_lifecycle
branch
from
67005e3 to
0629a62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires #3632.This modifies the lifecycle of peers to use the more modern
Runpattern that based on contexts.In particular, this replaces the
StartandWaitForDisconnectmethods with a single method namedRunand arranges for it to block until the provided context is cancelled or the peer is disconnected. This is more flexible for the caller since it can easily turn blocking code into async code while the reverse is not true.The new
Runmethod waits for all goroutines that it starts to shutdown before returning to help ensure an orderly shutdown.Since all exported methods that send messages to the various groroutines via channels already select across the
quitchannel which is closed when the peer disconnects, the peer is now forcibly disconnected when the context is cancelled.This approach allows the flexibility for callers to use any combination of manually disconnecting peers via the Disconnect method and allowing them to automatically be disconnected when the context is cancelled.
It also updates the server code accordingly.