Adds conditional to hanlde if redis becomes unavailable#22
Open
michaelerobertsjr wants to merge 5 commits intoded:masterfrom
Open
Adds conditional to hanlde if redis becomes unavailable#22michaelerobertsjr wants to merge 5 commits intoded:masterfrom
michaelerobertsjr wants to merge 5 commits intoded:masterfrom
Conversation
Owner
|
Hi @michaelerobertsjr thanks for your contribution! |
|
Any update on merging this change in? Its definitely a feature that I need. Thanks. |
68a3df5 to
7622797
Compare
Author
|
@ded Can you have a look now? Removed the double quotes, added white space, and removed the version bump. Thx. |
|
Any word on this getting merged? This is something I also need. @ded |
|
any follow up ? @ded |
Author
|
@ded bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice package!!
However using this in production (even with a highly available Redis cluster), means that the developer needs to handle if Redis becomes unavailable.
This is highly unlikely, but we would not want our rate limiter to kill our route if Redis has any issue(s).
It's pretty hard to swap out middleware in a running express app when it is setup like this:
I this was the simplest workaround I could think of. I will write some tests if you would like but, this patch is pretty easy to manually test...