Skip to content

Removed deprecated gulp-util dependency. #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FizzyGalacticus wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −12
Open

Removed deprecated gulp-util dependency. #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
var through = require('through2');
var gutil = require('gulp-util');
var PluginError = gutil.PluginError;
var PluginError = require('plugin-error');
var browserify = require('browserify');
var shim = require('browserify-shim');
var path = require('path');
Expand Down
9 changes: 5 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@
],
"dependencies": {
"browserify": "3.x",
"gulp-util": "~2.2.5",
"browserify-shim": "~2.0.10",
"plugin-error": "^1.0.1",
"readable-stream": "~1.1.10",
"through2": "~0.4.0"
"through2": "~0.4.0",
"vinyl": "^2.1.0"
},
"main": "index.js",
"engines": {
Expand All @@ -25,9 +26,9 @@
"test": "./node_modules/.bin/mocha"
},
"devDependencies": {
"mocha": "~1.17.1",
"chai": "~1.9.0",
"coffeeify": "~0.6.0"
"coffeeify": "~0.6.0",
"mocha": "~1.17.1"
},
"keywords": [
"gulpplugin",
Expand Down
1 change: 0 additions & 1 deletion test/fixtures/normal2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
var gutil = require('gulp-util');
11 changes: 6 additions & 5 deletions test/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
var fs = require('fs');
var path = require('path');
var gutil = require('gulp-util');
var File = require('vinyl');
var PluginError = require('plugin-error');
var coffeeify = require('coffeeify');
var expect = require('chai').expect;
var vm = require('vm')
Expand All @@ -10,7 +11,7 @@ var gulpB = require('../');
var prepare = require('./prepare');

function createFakeFile(filename, contents) {
return new gutil.File({
return new File({
cwd: process.cwd(),
base: path.join(__dirname, 'fixtures'),
path: path.join(__dirname, 'fixtures', filename),
Expand Down Expand Up @@ -295,7 +296,7 @@ describe('gulp-browserify', function() {
var fakeFile = createFakeFile('not_found.js', new Buffer('require("--non-existent");'));
gulpB().once('error', function (err) {
expect(err).to.exist;
expect(err).to.be.instanceof(gutil.PluginError);
expect(err).to.be.instanceof(PluginError);
expect(err.message).to.include('module "--non-existent" not found');
expect(err.stack).to.exist;
expect(err.plugin).to.eq('gulp-browserify');
Expand All @@ -309,7 +310,7 @@ describe('gulp-browserify', function() {
var opts = { transform: ['coffeeify'], extensions: ['.coffee'] };
gulpB(opts).once('error', function (err) {
expect(err).to.exist;
expect(err).to.be.instanceof(gutil.PluginError);
expect(err).to.be.instanceof(PluginError);
expect(err.message).to.include('test/fixtures/trans_error.coffee:2');
expect(err.message).to.include('ParseError: unexpected ');
expect(err.stack).to.exist;
Expand All @@ -329,7 +330,7 @@ describe('gulp-browserify', function() {
var opts = { transform: [stringErrorTransform], extensions: ['.coffee'] };
gulpB(opts).once('error', function (err) {
expect(err).to.exist;
expect(err).to.be.instanceof(gutil.PluginError);
expect(err).to.be.instanceof(PluginError);
expect(err.message).to.eq('string error!');
expect(err.plugin).to.eq('gulp-browserify');
expect(err.stack).to.exist;
Expand Down