Skip to content

fix: Modify MySQL and out-of-order configurations#11505

Merged
yuanchaoa merged 1 commit intomainfrom
modify-mysql-oor-configure
Mar 26, 2026
Merged

fix: Modify MySQL and out-of-order configurations#11505
yuanchaoa merged 1 commit intomainfrom
modify-mysql-oor-configure

Conversation

@yuanchaoa
Copy link
Contributor

This PR is for:

  • Agent

@yuanchaoa yuanchaoa force-pushed the modify-mysql-oor-configure branch 3 times, most recently from df28788 to afd34bf Compare March 26, 2026 10:25
@kylewanginchina
Copy link
Contributor

@claude review一下当前PR的代码修改

@claude
Copy link
Contributor

claude bot commented Mar 26, 2026

Claude finished @kylewanginchina's task in 36m 19s —— View job


Review

  • Read CLAUDE.md and inspect the relevant PR changes (CLAUDE.md was not present in this checkout)
  • Review the changed files for correctness, config behavior, and documentation consistency
  • Post review feedback with findings and summary in the PR comment

I checked the config definitions/wiring/runtime usage for the MySQL and OOOR/SR changes. I did not find a blocking code-path bug in the reviewed paths, but I found two user-facing documentation inconsistencies:

  1. MySQL endpoint_disabled documentation is inverted

    • Runtime behavior only generates the endpoint when the flag is false: agent/src/flow_generator/protocol_logs/sql/mysql.rs:459, agent/src/flow_generator/protocol_logs/sql/mysql.rs:484, agent/src/flow_generator/protocol_logs/sql/mysql.rs:488, agent/src/flow_generator/protocol_logs/sql/mysql.rs:1239.
    • However the docs currently say "After enabling..." while the option name/default are endpoint_disabled: true in:
      • server/agent_config/template.yaml:5995
      • server/agent_config/README.md:8413
      • server/agent_config/README-CH.md:8229
    • This describes the opposite of the real behavior. The wording should be changed to something like "set to false to extract SQL action/table information into endpoint", or the option should be renamed if the intended UX is positive-enable semantics.
  2. OOOR/SR docs do not mention the implicit Triple coupling

    • The normalization code enables all three protocols together whenever any one of HTTP2, gRPC, or Triple is configured: agent/src/config/config.rs:1393, agent/src/config/config.rs:1396, agent/src/config/config.rs:1400, agent/src/config/config.rs:1401, agent/src/config/config.rs:1402.
    • Those protocol names are all valid runtime values here: agent/src/common/l7_protocol_log.rs:99, agent/src/common/l7_protocol_log.rs:100, agent/src/common/l7_protocol_log.rs:101.
    • But the docs only say configuring HTTP2 or gRPC enables both, in:
      • server/agent_config/template.yaml:3275
      • server/agent_config/template.yaml:3320
      • server/agent_config/README.md:4437
      • server/agent_config/README.md:4514
      • server/agent_config/README-CH.md:4329
      • server/agent_config/README-CH.md:4403
    • That means users are not told that Triple is also implicitly enabled/linked in the same normalization path.

@yuanchaoa yuanchaoa force-pushed the modify-mysql-oor-configure branch from afd34bf to 6cc1bce Compare March 26, 2026 10:55
@rvql rvql enabled auto-merge (rebase) March 26, 2026 10:59
@rvql rvql disabled auto-merge March 26, 2026 10:59
@yuanchaoa yuanchaoa merged commit 505e566 into main Mar 26, 2026
11 checks passed
@yuanchaoa yuanchaoa deleted the modify-mysql-oor-configure branch March 26, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants