2026PKUCourseHW5：Improve error message in Fcoef::create#7131
Open
collapsar-z wants to merge 1 commit intodeepmodeling:developfrom
Open
2026PKUCourseHW5：Improve error message in Fcoef::create#7131collapsar-z wants to merge 1 commit intodeepmodeling:developfrom
collapsar-z wants to merge 1 commit intodeepmodeling:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the error message in
Fcoef::createinsource/source_pw/module_pwdft/soc.cpp.Motivation
The original error message
not allowed!was too vague and did not provide enough context for debugging invalid input dimensions.Changes
i1,i2, andi3Notes
This PR is submitted for PKU Parallel Programming Course HW5.