-
Notifications
You must be signed in to change notification settings - Fork 599
D0708 dpa3 default fparam #5340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
liuyuxiang92
wants to merge
27
commits into
deepmodeling:master
Choose a base branch
from
liuyuxiang92:D0708_dpa3_default_fparam
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,631
−199
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
b8c0859
feat(pt): add default_fparam
iProzd 28be7f6
Update stat.py
iProzd 503ec28
Write fparam/aparam statistic to stat_file (#47)
Chengqian-Zhang 82646e9
delete torch.jit.export of get_default_fparam (#51)
Chengqian-Zhang 13ee082
add edge readout
anyangml e14804d
add add_chg_spin_ebd
iProzd 58d8c10
update add_chg_spin_ebd for default fparam
iProzd c98b1fc
fix multitask
iProzd 82286fd
add update_use_layernorm
iProzd 7c2287e
add GatedMLP
iProzd 1404623
add add_case_embd
iProzd 219266c
Update training.py
iProzd e2777c0
feat: handle masked forces in test (#4893)
caic99 7f547b8
add use_default_pf
iProzd 773fb32
add init from direct model
iProzd a18fd72
Update training.py
iProzd 32b9431
add full default fparam
iProzd c471471
add argcheck for default_fparam
iProzd b37360a
Update argcheck.py
iProzd 6c90260
add f_use_norm
iProzd c39433b
new mae
iProzd 4e9e5ea
Update ener.py
iProzd 5808b2e
Update ener.py
iProzd ac5fbf9
fix fitting fparam stat
iProzd 4cc677d
fix huber with atom_pref
iProzd b4c8b60
fix has_default_fparam when dos or property
iProzd ad98d0d
feat: Add softmax to property for cooh nframes=3
liuyuxiang92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: deepmodeling/deepmd-kit
Length of output: 1725
🏁 Script executed:
Repository: deepmodeling/deepmd-kit
Length of output: 8519
🏁 Script executed:
Repository: deepmodeling/deepmd-kit
Length of output: 6378
🏁 Script executed:
Repository: deepmodeling/deepmd-kit
Length of output: 3029
Missing serialization and forwarding of three new RepFlowArgs parameters.
The three new parameters (
update_use_layernorm,use_gated_mlp,gated_mlp_norm) are stored as instance attributes but:Not serialized:
RepFlowArgs.serialize()omits these parameters. Models will lose them when saved/loaded.Not forwarded: These parameters are not passed to
DescrptBlockRepflows, andDescrptBlockRepflowsdoesn't accept them in its constructor. This indicates incomplete implementation—either they should be added toDescrptBlockRepflowsor they should not be inRepFlowArgsyet.🔧 Proposed fix for serialization
Add the missing parameters to
serialize():"use_dynamic_sel": self.use_dynamic_sel, "sel_reduce_factor": self.sel_reduce_factor, + "update_use_layernorm": self.update_use_layernorm, + "use_gated_mlp": self.use_gated_mlp, + "gated_mlp_norm": self.gated_mlp_norm, }🤖 Prompt for AI Agents