Fix JavaParser 3.28.0 API compatibility: Use TraditionalJavadocComment#85
Merged
eNeRGy164 merged 2 commits intodependabot/maven/com.github.javaparser-javaparser-symbol-solver-core-3.28.0from Feb 2, 2026
Conversation
Co-authored-by: eNeRGy164 <10671831+eNeRGy164@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Bump com.github.javaparser:javaparser-symbol-solver-core to 3.28.0
Fix JavaParser 3.28.0 API compatibility: Use TraditionalJavadocComment
Feb 2, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the codebase to be compatible with JavaParser 3.28.0, which changed JavadocComment from a concrete class to an abstract class with TraditionalJavadocComment as the concrete implementation.
Changes:
- Updated the visitor method signature in
AnalysisVisitorto acceptTraditionalJavadocCommentand added@Overrideannotation - Updated test code to instantiate
TraditionalJavadocCommentinstead ofJavadocComment
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/dev/dendrodocs/tool/AnalysisVisitor.java | Changed visitor method from JavadocComment to TraditionalJavadocComment parameter and added @Override annotation to properly override parent visitor method |
| src/test/java/dev/dendrodocs/tool/helpermethods/CommentHelperMethodsTest.java | Updated test instantiation from new JavadocComment(...) to new TraditionalJavadocComment(...) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5c18eda
into
dependabot/maven/com.github.javaparser-javaparser-symbol-solver-core-3.28.0
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaParser 3.28.0 changed
JavadocCommentfrom a concrete class to an abstract class, introducingTraditionalJavadocCommentas the concrete implementation.Changes
visit(JavadocComment n, Analyzer arg)tovisit(TraditionalJavadocComment n, Analyzer arg)and added@Overrideannotation to properly override the visitor method fromGenericListVisitorAdapternew JavadocComment(...)tonew TraditionalJavadocComment(...)JavadocComment(abstract parent) for compatibility with all subclassesThe visitor pattern in 3.28.0 exposes
visit(TraditionalJavadocComment, A)instead ofvisit(JavadocComment, A), requiring the method signature change to properly override the parent class method.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.