Skip to content

feat(xml/unstable): add XML 1.1 support#7057

Open
tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
tomas-zijdemans:xml11-only-main
Open

feat(xml/unstable): add XML 1.1 support#7057
tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
tomas-zijdemans:xml11-only-main

Conversation

@tomas-zijdemans
Copy link
Contributor

@tomas-zijdemans tomas-zijdemans commented Mar 20, 2026

I went for no version auto-detection from  <?xml version="...">. Users explicitly set xmlVersion: "1.1". The reasoning for this is that it's very very common to encounter XML files where the version is not honest, so It would just confuse users. The alternative would be a opaque strict or lenient mode.

I checked XML 1.1
conformance against the official XML test suite.

The XML module gets improved test coverage with this PR

@github-actions github-actions bot added the xml label Mar 20, 2026
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 91.40271% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.37%. Comparing base (260f5b8) to head (fe9a1c9).

Files with missing lines Patch % Lines
xml/_tokenizer.ts 87.65% 3 Missing and 7 partials ⚠️
xml/_parse_sync.ts 90.90% 0 Missing and 7 partials ⚠️
xml/_entities.ts 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7057      +/-   ##
==========================================
- Coverage   94.38%   94.37%   -0.02%     
==========================================
  Files         628      628              
  Lines       50175    50219      +44     
  Branches     8840     8863      +23     
==========================================
+ Hits        47357    47393      +36     
+ Misses       2251     2249       -2     
- Partials      567      577      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant