Refactor Helm installation script to use local GPG keys file #1529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the download of GPG keys from GitHub. - Eliminated the function for checking reachable GPG key servers. - Updated the script to copy a local KEYS file instead.
Contributor
|
@KarstenB Thanks for raising this. I agree that there should be a solution for slowdowns caused by pgp.com issues, but I'm not sure this is the correct approach. Instead, I would rather we address the root cause (fetching being slow). If that is not possible, could we consider a hybrid (opt-in) approach to using a local key? We also need to consider the precedent of storing all keys used in the repo locally; I'm not sure this is ideal. |
Contributor
|
cc @chrmarti who may have a better idea regarding this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach eliminates pgp.com server down issue like #1272 and can sometimes improve build performance. The only downside is that the KEYS file needs to be updated when upstream updates it. But a quick check of https://github.com/helm/helm/commits/main/KEYS shows that those are very infrequent.