Handle PowerShell RC versions in preview install path#1608
Draft
Handle PowerShell RC versions in preview install path#1608
Conversation
- Add -rc. version checks alongside preview checks in routing conditions so RC versions go directly to GitHub install instead of apt/dnf - Update find_preview_version_from_git_tags() to match -rc.X git tags - Fix typo googlegit_cmd_name -> git_cmd_name - Update preview test scripts to match both preview and rc.X patterns Co-authored-by: Kaniska244 <186041440+Kaniska244@users.noreply.github.com> Agent-Logs-Url: https://github.com/devcontainers/features/sessions/03fd0565-a230-4bd9-80f7-92b8ce74a1bb
Copilot created this pull request from a session on behalf of
Kaniska244
March 25, 2026 10:08
View session
Contributor
|
@copilot Pls do a version bump. |
Co-authored-by: Kaniska244 <186041440+Kaniska244@users.noreply.github.com> Agent-Logs-Url: https://github.com/devcontainers/features/sessions/98f1f7bd-4d93-4641-85d8-287b218c1eb8
Contributor
Author
Done — bumped powershell feature version from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft's preview redirect (
aka.ms/powershell-release?tag=preview) now resolves to RC versions (e.g.,7.6.0-rc.1) instead of-preview.Xversions. The install script only checked for the string"preview"in version routing, so RC versions fell through to the apt/dnf codepath (which doesn't carry them) and then failed again in the GitHub fallback's stable version resolver.Fixes the failing
test-scenarios (powershell)CI job (job link).Changes
src/powershell/install.sh!= *"-rc."*guards alongside existing!= *"preview"*checks so RC versions skip apt/dnf and go straight to GitHub release download*"-rc."*versions throughfind_preview_version_from_git_tagsinstead of the stable-onlyfind_version_from_git_tags-preview\.[0-9]+to-(preview|rc)\.[0-9]+so RC tags are discoverablegooglegit_cmd_name→git_cmd_nametest/powershell/powershell_preview_version*.shgrep -i 'preview'togrep -iE 'preview|rc\.[0-9]+'sincepwsh --versionreportsPowerShell 7.6.0-rc.1for RC builds