-
Notifications
You must be signed in to change notification settings - Fork 373
Update Ruby version to 4.0 and adjust related documentation #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
ebf9d17
511611c
542e4fd
b94a895
592dc51
968d8cd
2f15806
0313fd6
85a5f50
8d4e7c3
81b83cf
448d9e8
d7bb100
52634c6
0ef56b9
c68767e
13aebcc
b3a08eb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| { | ||
| "name": "Ruby", | ||
| // Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile | ||
| "image": "mcr.microsoft.com/devcontainers/ruby:2-${templateOption:imageVariant}" | ||
| "image": "mcr.microsoft.com/devcontainers/ruby:3-${templateOption:imageVariant}" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this not be
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The current supported image manifest version is 3. Version 4 has not yet been released. Attempting to use version 4 in place of version 3 will result in a failure when pulling the image. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have I also see |
||
|
|
||
| // Features to add to the dev container. More info: https://containers.dev/features. | ||
| // "features": {}, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ Develop Ruby based applications. includes everything you need to get up and runn | |
|
|
||
| | Options Id | Description | Type | Default Value | | ||
| |-----|-----|-----|-----| | ||
| | imageVariant | Ruby version (use -trixie, -bookworm, -bullseye variants on local arm64/Apple Silicon) : | string | 3.4-trixie | | ||
| | imageVariant | Ruby version (use -trixie, -bookworm, -bullseye variants on local arm64/Apple Silicon) : | string |4.0-trixie | | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also should be |
||
|
|
||
| This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata. | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "id": "ruby", | ||
| "version": "5.0.0", | ||
| "version": "6.0.0", | ||
| "name": "Ruby", | ||
| "description": "Develop Ruby based applications. includes everything you need to get up and running.", | ||
| "documentationURL": "https://github.com/devcontainers/templates/tree/main/src/ruby", | ||
|
|
@@ -11,20 +11,20 @@ | |
| "type": "string", | ||
| "description": "Ruby version (use -trixie, -bookworm, -bullseye variants on local arm64/Apple Silicon):", | ||
| "proposals": [ | ||
| "3-trixie", | ||
| "4.0-trixie", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't these also be |
||
| "3.4-trixie", | ||
| "3.3-trixie", | ||
| "3.2-trixie", | ||
| "3-bookworm", | ||
| "4.0-bookworm", | ||
| "3.4-bookworm", | ||
| "3.3-bookworm", | ||
| "3.2-bookworm", | ||
| "3-bullseye", | ||
| "4.0-bullseye", | ||
| "3.4-bullseye", | ||
| "3.3-bullseye", | ||
| "3.2-bullseye" | ||
| ], | ||
| "default": "3.4-trixie" | ||
| "default": "4.0-trixie" | ||
| } | ||
| }, | ||
| "platforms": ["Ruby"], | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be 4-trixie, since we don't have 4.0-trixie now?