Fix all issues and add more features#103
Open
paty-oliveira wants to merge 5 commits intodeveloper-job-simulation:mainfrom
Open
Fix all issues and add more features#103paty-oliveira wants to merge 5 commits intodeveloper-job-simulation:mainfrom
paty-oliveira wants to merge 5 commits intodeveloper-job-simulation:mainfrom
Conversation
paty-oliveira
commented
Aug 9, 2023
paty-oliveira
commented
- Fix issue about the company name not appearing
- Transform created_at column into readable format
- Transform revenue_ytd column into readable format
- Make table looks prettier
sbmsr
reviewed
Aug 9, 2023
Member
There was a problem hiding this comment.
Great job formatting the COMPANIES_TABLE_HEADERS array to have each item on a new line. It improves readability. However, it seems that the COMPANY_NAME_FIELD_NAME constant was changed from company_name to name. Please confirm if this was intentional.
Author
There was a problem hiding this comment.
It was intentional! Based on my understanding, it is the fix for the undefined company name. It is based on db.json fields, where the name field is the company name not company_name. However, let me know if I'm not thinking correctly 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.