finished all tasks#106
Open
RalphOrland wants to merge 2 commits intodeveloper-job-simulation:mainfrom
Open
Conversation
now I wait
sbmsr
reviewed
Sep 7, 2023
Member
There was a problem hiding this comment.
Consider using a more descriptive key name like 'company_name' instead of 'name' for the 'companies' array items.
sbmsr
reviewed
Sep 7, 2023
Member
There was a problem hiding this comment.
I have some feedback on the code:
- It looks like there are some unnecessary blank lines in the code. Please remove them.
- The function
formatTimeFromCreatedAtandformatNumberWithSpacesare defined inside themakeTablefunction. It's generally better to define them outside so they can be reused. - The commented out code for local time is unnecessary and can be removed.
Other than that, the code looks good!
sbmsr
reviewed
Sep 7, 2023
Member
There was a problem hiding this comment.
Great job on the changes! I have a couple of suggestions:
- In line 7, instead of using
lightblue, it might be better to use a more descriptive color name. - In line 12, there seems to be an extra whitespace after the colon.
Other than that, the code looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now I wait