Open
Conversation
sbmsr
reviewed
Sep 8, 2023
Member
There was a problem hiding this comment.
The code changes look good overall. Here are a few suggestions:
- It would be better to use single quotes consistently for string literals throughout the file.
- The indentation of the try-catch block is inconsistent. Please make sure it aligns with the surrounding code.
- Consider adding a comment explaining why the error is being rethrown.
Great job on handling the error and rethrowing it to avoid returning undefined!
sbmsr
reviewed
Sep 8, 2023
Member
There was a problem hiding this comment.
Great job on this PR! I have a couple of suggestions:
-
In the
COMPANIES_API_PATHconstant, please use double quotes instead of single quotes for consistency. -
It would be great to add a newline at the end of the file to follow common coding conventions.
Other than that, the changes look good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.