Skip to content

chore: rebase redfish branch with console v1.21.3#818

Closed
sudhir-intc wants to merge 17 commits intoredfishfrom
rf-rebase-v1.21.3
Closed

chore: rebase redfish branch with console v1.21.3#818
sudhir-intc wants to merge 17 commits intoredfishfrom
rf-rebase-v1.21.3

Conversation

@sudhir-intc
Copy link
Contributor

This PR rebases a branch created from tag v1.21.3 onto redfish to preserve commit history while integrating redfish changes.

Flow used:

  • Create rf-rebase-v1.21.3 from tag v1.21.3
  • Rebase rf-rebase-v1.21.3 onto redfish
  • Open PR from rf-rebase-v1.21.3 to redfish

Note: target branch is redfish (not main).

madhavilosetty-intel and others added 17 commits March 2, 2026 10:47
…ges/v2 (#795)

Bumps [github.com/device-management-toolkit/go-wsman-messages/v2](https://github.com/device-management-toolkit/go-wsman-messages) from 2.36.1 to 2.36.2.
- [Release notes](https://github.com/device-management-toolkit/go-wsman-messages/releases)
- [Commits](device-management-toolkit/go-wsman-messages@v2.36.1...v2.36.2)

---
updated-dependencies:
- dependency-name: github.com/device-management-toolkit/go-wsman-messages/v2
  dependency-version: 2.36.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Madhavi Losetty <madhavi.losetty@intel.com>
Bumps [modernc.org/sqlite](https://gitlab.com/cznic/sqlite) from 1.44.3 to 1.45.0.
- [Changelog](https://gitlab.com/cznic/sqlite/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/cznic/sqlite/compare/v1.44.3...v1.45.0)

---
updated-dependencies:
- dependency-name: modernc.org/sqlite
  dependency-version: 1.45.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Madhavi Losetty <madhavi.losetty@intel.com>
Prevent EnforceSecureBoot from being disabled when the device is in Client Control Mode (CCM).
The bootOptions now checks the provisioning mode and returns a 400 error if EnforceSecureBoot is set to false in CCM.
…ring them (#778)

* fix: handle password encryption errors in dtoToEntity functions

* fix: handle errors in decrypt and fix UT
* feat: add KVM performance timing metrics and monitoring

- Add histograms to track KVM connection setup timing:
  - Device lookup time from database
  - TCP connection establishment time
  - WebSocket upgrade duration
  - Total connection time
  - Consent code wait time
  - API request durations
- Add metrics for KVM data flow performance:
  - Device-to-browser and browser-to-device write/send durations
  - Payload size distributions
  - Receive/read block times
- Create recording functions for all metrics
- Add detailed timing logs with KVM_TIMING prefix
- Update tests to handle new timing metrics

* refactor: replace manual REST endpoint instrumentation with go-gin-prometheus

Replace manual timing instrumentation in individual REST endpoints with
go-gin-prometheus middleware for automatic metrics coverage across all
HTTP endpoints.

Changes:
- Add go-gin-prometheus dependency to provide standard HTTP metrics
- Integrate Prometheus middleware in router for automatic instrumentation
- Remove manual timing code from features, KVM displays, and power endpoints
- Remove unused kvmAPIRequestSeconds metric and RecordAPIRequest function
- Clean up unused time and devices package imports

Benefits:
- Automatic metrics for ALL REST endpoints (not just 3)
- Standard HTTP metrics (duration, status codes, request/response sizes)
- Less repetitive code and improved maintainability
- Keeps all custom KVM connection and data flow metrics

Addresses reviewer feedback in PR #761

---------

Co-authored-by: Mike <michael.johanson@intel.com>
…ection (#776) (#788)

1. Initialize APF session timer to prevent nil pointer dereference
   during CIRA connection cleanup.
2. Replace direct CIM.Chip.Get() calls with Enumerate+Pull pattern to handle
   empty/malformed chip data gracefully and prevent connection termination.
Bumps [modernc.org/sqlite](https://gitlab.com/cznic/sqlite) from 1.45.0 to 1.46.1.
- [Changelog](https://gitlab.com/cznic/sqlite/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/cznic/sqlite/compare/v1.45.0...v1.46.1)

---
updated-dependencies:
- dependency-name: modernc.org/sqlite
  dependency-version: 1.46.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: DevipriyaS17 <devipriya.s@intel.com>
…0.3 (#811)

Bumps [github.com/zsais/go-gin-prometheus](https://github.com/zsais/go-gin-prometheus) from 1.0.2 to 1.0.3.
- [Release notes](https://github.com/zsais/go-gin-prometheus/releases)
- [Commits](zsais/go-gin-prometheus@v1.0.2...v1.0.3)

---
updated-dependencies:
- dependency-name: github.com/zsais/go-gin-prometheus
  dependency-version: 1.0.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… DHCP is false (#799)

Co-authored-by: Madhavi Losetty <madhavi.losetty@intel.com>
Co-authored-by: Sudhir Pola <sudhir.pola@intel.com>
Co-authored-by: Mike <michael.johanson@intel.com>
also ensure JWT signatures matches expected
@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 98 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (redfish@937f959). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/usecase/devices/interceptor.go 31.03% 18 Missing and 2 partials ⚠️
cmd/app/browser.go 63.63% 8 Missing ⚠️
internal/usecase/profiles/usecase.go 50.00% 4 Missing and 4 partials ⚠️
internal/usecase/wificonfigs/usecase.go 46.66% 5 Missing and 3 partials ⚠️
internal/usecase/ciraconfigs/usecase.go 53.84% 3 Missing and 3 partials ⚠️
internal/usecase/devices/metrics.go 40.00% 6 Missing ⚠️
internal/usecase/domains/usecase.go 50.00% 3 Missing and 3 partials ⚠️
internal/controller/tcp/cira/tunnel.go 44.44% 5 Missing ⚠️
cmd/app/main.go 69.23% 4 Missing ⚠️
internal/controller/httpapi/v1/login.go 0.00% 4 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             redfish     #818   +/-   ##
==========================================
  Coverage           ?   34.24%           
==========================================
  Files              ?      135           
  Lines              ?    14125           
  Branches           ?        0           
==========================================
  Hits               ?     4837           
  Misses             ?     8854           
  Partials           ?      434           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sudhir-intc sudhir-intc closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants