Draft
Conversation
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Tom Plant <tom@tplant.com.au>
7zip, SFXCab, InstallShield, WExtract Signed-off-by: Tom Plant <tom@tplant.com.au>
Signed-off-by: Tom Plant <tom@tplant.com.au>
Signed-off-by: Tom Plant <tom@tplant.com.au>
Tested with Sonos.Controller Signed-off-by: Tom Plant <tom@tplant.com.au>
Nasty hack, needs more reversing. Appears to have no file index, instead storing name+contents inline. There must be a size too but I can't find it Signed-off-by: Tom Plant <tom@tplant.com.au>
Signed-off-by: Tom Plant <tom.plant@devicie.com>
Co-authored-by: pl4nty <21111317+pl4nty@users.noreply.github.com>
…timize string allocation Co-authored-by: pl4nty <21111317+pl4nty@users.noreply.github.com>
… string concatenation Co-authored-by: pl4nty <21111317+pl4nty@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement and test GitHub issue 1512
Add .appinstaller file support
Dec 8, 2025
pl4nty
requested changes
Dec 8, 2025
…installers folder Co-authored-by: pl4nty <21111317+pl4nty@users.noreply.github.com>
Co-authored-by: pl4nty <21111317+pl4nty@users.noreply.github.com>
601dee8 to
01c2327
Compare
Copilot stopped work on behalf of
pl4nty due to an error
December 15, 2025 01:58
ab41c24 to
79d2c08
Compare
ea5425d to
044aba7
Compare
e368a16 to
b703355
Compare
29c0733 to
b2be670
Compare
7f8f858 to
0e502c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Plan for .appinstaller File Support
.appinstallerextension constant tosrc/analysis/extensions.rssrc/analysis/installers/msix_family/appinstaller.rsto parse .appinstaller XML files.appinstallerfilesSummary
Successfully implemented .appinstaller file support with clean git history:
Current State: 5 commits on top of main (01c2327)
29bc984- Add .appinstaller file support with XML parsing and URL resolutionb0a88ef- Address code review feedback: add logging for parsing failures and optimize string allocation46ff612- Use APPINSTALLER constant consistently with formatcp for compile-time string concatenatione459d70- Refactor appinstaller to use serde deserialization and move logic to installers folder28df323- Optimize get_installer_url to take ownership instead of cloningChanges: 5 files modified (173 insertions, 1 deletion)
src/analysis/extensions.rssrc/analysis/installers/msix_family/appinstaller.rs(new)src/analysis/installers/msix_family/mod.rssrc/analysis/mod.rssrc/download/downloader.rsTests: All 104 tests passing, including real URL integration test
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.