compiler: Enhance detect_accesses and patch symbolic padding#2886
compiler: Enhance detect_accesses and patch symbolic padding#2886FabioLuporini wants to merge 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2886 +/- ##
==========================================
- Coverage 83.43% 82.87% -0.57%
==========================================
Files 248 248
Lines 51381 51470 +89
Branches 4431 4433 +2
==========================================
- Hits 42871 42656 -215
- Misses 7757 8049 +292
- Partials 753 765 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| # Search among the Indexeds (Most accesses typically stem from Indexeds) | ||
| plain_indexeds = retrieve_indexed(exprs, deep=True) | ||
|
|
||
| # Search among higher order objects, which still represent meaningful accesses |
There was a problem hiding this comment.
This look very specific and seems like that's something retrieve_index should catch
There was a problem hiding this comment.
the idea is that other objects can end up there, in the future, maybe...
as for retrieve_indexed catching it: disagree, it's not an implicit Indexed, it's rarther a logical representation of the base address of the TensorMove -- as an Indexed, for homogeneity
Test in PRO in the PR/branch with same name as this one