feat: add support for content types ending in +json#22
Open
hansgoed wants to merge 1 commit intodevlikeapro:mainfrom
Open
feat: add support for content types ending in +json#22hansgoed wants to merge 1 commit intodevlikeapro:mainfrom
hansgoed wants to merge 1 commit intodevlikeapro:mainfrom
Conversation
devlikepro
approved these changes
Aug 25, 2025
Contributor
devlikepro
left a comment
devlikepro
left a comment
There was a problem hiding this comment.
Probably we should move the regexp into the config to avoid issues when multiple schemas are defined in the OpenAPI spec, since the regexp would otherwise just match the first one.
Something like N8NPropertiesBuilderConfig.contentTypeRegex.
That way we can pass it to the builders, and they’ll use it consistently.
devlikepro
requested changes
Aug 25, 2025
Contributor
devlikepro
left a comment
devlikepro
left a comment
There was a problem hiding this comment.
Sorry, I actually meant to request changes :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only
application/jsonworks as a content type. I expanded the regex to allowapplication/{anything}+json.