#6: implemented naming convention tests N3 & N4#11
Conversation
hohwille
left a comment
There was a problem hiding this comment.
@zichriste Thanks for the PR. Excellent. Simple and straight forward-solution (was more complex in sonarqube due to lack of inheritance check). 👍
Due to missing classes needed by naming convention rules N1, N2, and N5 to N8, the implementation of these rules has not been handled in this task.
Let us simply add a TaskListCto derived from AbstractCto. I can not do that before Thursday, but then I should find some time to extend our demo app.
What we can still discuss: First of all I like it to have separate JUnits for the different types of rules (Separation of concerns). However, I have seen projects putting all arch-unit checks always into a single JUnit. Does this have any performance-impact due to caching? If not, I would love to stay with your approach and we could already merge this PR as is.
|
@zichriste For the record: I found some minutes to extended our little sample app to come with a CTO example as well so N1 can be implemented now. Also for N5 I introduced
|
|
Now green, hence I am merging :) |
Due to missing classes needed by naming convention rules N1, N2, and N5 to N8, the implementation of these rules has not been handled in this task.