#3: implementation component rules C5 - C7 - violations

[NicolasVanBellen]

#3
DO NOT MERGE
This fork branch contains classes demonstrating archunit component rules violations:
Rules C5 - C7

[hohwille]

https://github.com/devonfw/devon4j/blob/master/documentation/architecture.asciidoc#technical-architecture

The term Layer is not part of the package definition. It is just logic, dataaccess, batch, etc.

[NicolasVanBellen]

that was a following mistake from my misunderstanding earlier. I will fix that now.

[hohwille]

@NicolasVanBellen thanks for your PR with the violations. Looks good. 👍
I left a small comment for you to have a look.

BTW: In Java by conventions package segments are lowercaseonly so no pascalCase like componentA would be used to follow best-practices. However, in this case where we actually demonstrate anti-patterns this is fully fine.

[hohwille]

The violation messages from your ArchUnit rules look very clear and self-explanatory to me:

Error:  Failures: 
Error:    Architecture Violation [Priority: MEDIUM] - Rule 'Code from dataaccess layer shall not depend on dataaccess layer of a different component.' was violated (1 times):
'componentA.dataaccess' is dependend on 'task.dataaccess'. Violated in: (Class <com.devonfw.sample.archunit.componentA.dataaccess.C6ViolationDataaccessLayerOfComponentADependsOnDataaccessLayerOfComponentTask>). Dependency towards (Class <com.devonfw.sample.archunit.task.dataaccess.TaskItemEntity>)
Error:    Architecture Violation [Priority: MEDIUM] - Rule 'Code from logic layer of a component shall not depend on dataaccess layer of a different component.' was violated (1 times):
'componentA.logic' is dependend on 'task.dataaccess'. Violated in: (Class <com.devonfw.sample.archunit.componentA.logic.C5ViolationLogicLayerOfComponentADependsOnDataaccessLayerOfComponentTask>). Dependency towards (Class <com.devonfw.sample.archunit.task.dataaccess.TaskItemEntity>)

However, due to the comment I already left, you are violating a different rule than you actually intended:

Error:    Architecture Violation [Priority: MEDIUM] - Rule 'classes should check for the package structure to be valid' was violated (2 times):
C5ViolationLogicLayerOfComponentADependsOnDataaccessLayerOfComponentTask test result is false
C6ViolationDataaccessLayerOfComponentADependsOnDataaccessLayerOfComponentTask test result is false