fix: remove redundant $dimensionsString block#72
Open
piyush140104 wants to merge 1 commit intodevsecopsmaturitymodel:mainfrom
Open
fix: remove redundant $dimensionsString block#72piyush140104 wants to merge 1 commit intodevsecopsmaturitymodel:mainfrom
piyush140104 wants to merge 1 commit intodevsecopsmaturitymodel:mainfrom
Conversation
Collaborator
|
Being a security app we would like all contribution to be signed. Could you set up a GPG key, like described in CONTRIBUTING.md, please @piyush140104 ? |
piyush140104
force-pushed
the
fix/remove-depreciated-dimensionsString-block
branch
from
d3fa844 to
14e0945
Compare
Author
|
Done @vbakke, commits are now GPG signed. Please let me know if anything else is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed lines 166-174 in
yaml-generation/generateDimensions.php. The variable$dimensionsStringwas computed and post processed but never used anywhere after line 174. The actual variable that stores the model.yaml content is$modelStringwhich is what gets saved to the file. Lines 166-174 were doing the exact same post processing as lines 186-193 but for a variable that was never written to any file.Reviewers
@vbakke
Closes
Issue number: #71