fix: add missing alt attribute to logo for accessibility#516
Closed
inchara13kuppal wants to merge 1 commit intodevsecopsmaturitymodel:mainfrom
Closed
fix: add missing alt attribute to logo for accessibility#516inchara13kuppal wants to merge 1 commit intodevsecopsmaturitymodel:mainfrom
inchara13kuppal wants to merge 1 commit intodevsecopsmaturitymodel:mainfrom
Conversation
777169a to
2608fd4
Compare
2608fd4 to
1c796b4
Compare
Collaborator
|
This pull request contains 10 changes that has nothing to do with the description. Not saying the changes are not good improvements. But it makes it hard to keep a tidy flow. As for the missing alt, https://www.w3.org/WAI/tutorials/images/decision-tree/ says implies that an empty I'm sorry, I will close this request. It's fine do group similar changes in one request. But please describe them, and consider which files are included in a particular request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of my familiarization with the DSOMM frontend architecture for my GSoC 2026 proposal, I noticed a minor web accessibility (A11y) gap. The main logo was missing a descriptive
altattribute, which is flagged by screen readers and accessibility audits.Changes Made
altattribute to the<img>tag in the logo component.Testing
npm run lintpasses with zero errors.