Skip to content

chore: retry StatusCode::SERVICE_UNAVAILABLE #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mraszyk wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

chore: retry StatusCode::SERVICE_UNAVAILABLE #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc3334a
chore: retry StatusCode::SERVICE_UNAVAILABLE
mraszyk Jan 11, 2026
2dea2b1
changelog
mraszyk Jan 11, 2026
716bc6c
Merge branch 'main' into mraszyk/retry-service-unavailable
mraszyk Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

* Fix `StatusCode::SERVICE_UNAVAILABLE` in `ic-agent`.
* Time out `Unknown` statuses after 5 minutes, regardless of the configured `max_polling_time`.

### Breaking Changes
Expand Down
9 changes: 6 additions & 3 deletions ic-agent/src/agent/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ impl Agent {
/// Create an instance of an [`Agent`].
pub fn new(config: agent_config::AgentConfig) -> Result<Agent, AgentError> {
let client = config.http_service.unwrap_or_else(|| {
Arc::new(Retry429Logic {
Arc::new(RetryLogic {
client: config.client.unwrap_or_else(|| {
#[cfg(not(target_family = "wasm"))]
{
Expand Down Expand Up @@ -2237,13 +2237,13 @@ where
}

#[derive(Debug)]
struct Retry429Logic {
struct RetryLogic {
client: Client,
}

#[cfg_attr(target_family = "wasm", async_trait(?Send))]
#[cfg_attr(not(target_family = "wasm"), async_trait)]
impl HttpService for Retry429Logic {
impl HttpService for RetryLogic {
async fn call<'a>(
&'a self,
req: &'a (dyn Fn() -> Result<http::Request<Bytes>, AgentError> + Send + Sync),
Expand Down Expand Up @@ -2275,6 +2275,9 @@ impl HttpService for Retry429Logic {
crate::util::sleep(Duration::from_millis(250)).await;
continue;
}
} else if resp.status() == StatusCode::SERVICE_UNAVAILABLE {
crate::util::sleep(Duration::from_millis(250)).await;
continue;
} else {
break Ok(resp);
}
Expand Down
Loading