-
Notifications
You must be signed in to change notification settings - Fork 4
chore: release #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release #71
Conversation
065bd0a to
22cf222
Compare
gregorydemay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the release, a minor comment about the verisoning of ic-agent-canister-runtime
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [0.1.2] - 2026-01-30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why increasing the patch number? AFAIK this is not a bug fix release so I would go with 0.2.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I generally try to avoid bumping the major version for such a small change (just dependency updates here) since this breaks Cargo compatibility. From the docs:
This guide uses the terms βmajorβ and βminorβ assuming this relates to a β1.0.0β release or later. Initial development releases starting with β0.y.zβ can treat changes in βyβ as a major release, and βzβ as a minor release. β0.0.zβ releases are always major changes. This is because Cargo uses the convention that only changes in the left-most non-zero component are considered incompatible.
According to semver.org though:
Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.
I guess the right thing to do would be to just bump to v1.0.0 here sooner rather than later... WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks for the explanation! Let's follow the more specific guidelines from Cargo then. I think we should bump everything to v1 once we have JSON-RPC batch used in the EVM RPC canister, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
π€ New release
canhttp: 0.4.0 -> 0.5.0 (β API compatible changes)ic-canister-runtime: 0.1.1 -> 0.1.2 (β API compatible changes)ic-pocket-canister-runtime: 0.2.0 -> 0.3.0 (β API breaking changes)ic-agent-canister-runtime: 0.1.1 -> 0.1.2 (β API compatible changes)Changelog
canhttpic-canister-runtimeic-pocket-canister-runtimeic-agent-canister-runtimeThis PR was generated with release-plz.