Replace deprecated jax context manager and JIT-traced non-array arguments#260
Open
hannes-holey wants to merge 9 commits intodfm:mainfrom
Open
Replace deprecated jax context manager and JIT-traced non-array arguments#260hannes-holey wants to merge 9 commits intodfm:mainfrom
hannes-holey wants to merge 9 commits intodfm:mainfrom
Conversation
dfm
requested changes
Jan 29, 2026
Owner
dfm
left a comment
There was a problem hiding this comment.
Thanks!! Small comment inline, otherwise looks good to me!
src/tinygp/test_utils.py
Outdated
| ) | ||
|
|
||
|
|
||
| def _as_context_manager(obj): |
Owner
There was a problem hiding this comment.
I think this is more complicated than it needs to be. Let's just switch to using jax.enable_x64 everywhere where we were using the experimental version!
Author
There was a problem hiding this comment.
I agree. If you are okay with dropping Python 3.10 I will make that change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thank you for tinygp.
This PR attempts to replace the
jax.experimental.enable_x64context manager which is deprecated injax>=0.9.0.While testing this change on current GitHub runners some other JAX-related issues surfaced:
See details
As far as I can tell, the problem was the None attribute of the
Meanclass when initiated with a callable. This PR should fix this by setting itsvalueattribute to a valid (dummy) JAX array.