Skip to content

Bug/handle invalid rolspan and colspan#64

Merged
dfop02 merged 1 commit intorelease/1.1.4from
bug/handle-invalid-rolspan-and-colspan
Feb 21, 2026
Merged

Bug/handle invalid rolspan and colspan#64
dfop02 merged 1 commit intorelease/1.1.4from
bug/handle-invalid-rolspan-and-colspan

Conversation

@dfop02
Copy link
Owner

@dfop02 dfop02 commented Feb 21, 2026

Description

Handle invalid rowspan and colspan values gracefully.

Instead of raising an exception and crashing when a non-numeric or invalid value is provided, we now default both attributes to 1. This ensures table rendering continues safely and aligns with standard HTML behavior, improving robustness and fault tolerance.

This fix was originally made by kko-harvey on PR#56. The original PR was not merged and completed due to lack of response.

Issue Reference

No Issue

Checklist Before Requesting a Review

  • I have performed a self-review of my code.
  • My code follows the project's coding style and guidelines.
  • I have run tests and verified that all existing and new tests pass.
  • I have added new tests to cover my changes.

@dfop02 dfop02 self-assigned this Feb 21, 2026
@dfop02 dfop02 added the bug Something isn't working label Feb 21, 2026
@dfop02 dfop02 changed the base branch from main to release/1.1.4 February 21, 2026 18:53
@dfop02 dfop02 merged commit 4bca1af into release/1.1.4 Feb 21, 2026
6 checks passed
@dfop02 dfop02 deleted the bug/handle-invalid-rolspan-and-colspan branch February 21, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant