Open
Conversation
- Fix clean-all blocking non-interactively: guard the confirmation prompt with
`[ -t 0 ]` so it is only shown when stdin is a terminal; add
`stdin=subprocess.DEVNULL` in run_make_command to make the tty check reliable
when called from pytest
- Fix dirty-volume restore: change test_clean_environment to call `clean-all`
instead of `clean`; `make clean` does not remove named volumes, leaving stale
postgres/dhis2 data that corrupts the restore test cycle
- Fix DHIS2 42 UI selector: update `get_by_title("Profile menu")` to
`get_by_title("header bar profile")` in both test files; the header bar
profile button title changed in DHIS2 42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.