Support l1 weights in B slice header#95
Closed
Yang2096 wants to merge 1 commit intodholroyd:masterfrom
Closed
Conversation
Collaborator
|
Thanks! The code looks correct to me. Could you throw in a test and a "BREAKING CHANGE:" entry in |
Contributor
Author
|
It is hard to find or create a video that contains such slice header, i tried to encode a video using ffmpeg with |
Owner
|
Looks like I implemented this in 27c6da1 having forgotten that this PR was open - sorry 😓 Do the changes in master meet your needs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the H264 specification
7.3.3.2 Prediction weight table syntax, there is two layers of luma/chroma weight in B slice header.