Skip to content

Handle empty type in incremental SMT2 decision procedure#8907

Draft
tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig:fix-8077-smt2-incr-empty
Draft

Handle empty type in incremental SMT2 decision procedure#8907
tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig:fix-8077-smt2-incr-empty

Conversation

@tautschnig
Copy link
Copy Markdown
Collaborator

Skip symbols and nondet symbols with empty_typet (void) in gather_dependent_expressions to avoid attempting SMT sort conversion. Add early return in send_function_definition for empty-typed expressions as a defensive measure. Handle equality over empty type in set_to by treating it as vacuously true, matching the behavior of the non-incremental SMT2 backend.

Remove no-new-smt exclusion tag from havoc_slice_checks and memset_null regression tests since they now pass with the incremental SMT2 backend.

Fixes: #8077

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Skip symbols and nondet symbols with empty_typet (void) in
gather_dependent_expressions to avoid attempting SMT sort conversion.
Add early return in send_function_definition for empty-typed
expressions as a defensive measure. Handle equality over empty type
in set_to by treating it as vacuously true, matching the behavior
of the non-incremental SMT2 backend.

Remove no-new-smt exclusion tag from havoc_slice_checks and
memset_null regression tests since they now pass with the
incremental SMT2 backend.

Fixes: diffblue#8077
@tautschnig tautschnig self-assigned this Mar 28, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.41%. Comparing base (0170409) to head (cf62050).

Files with missing lines Patch % Lines
...ncremental/smt2_incremental_decision_procedure.cpp 80.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8907   +/-   ##
========================================
  Coverage    80.41%   80.41%           
========================================
  Files         1703     1703           
  Lines       188398   188407    +9     
  Branches        73       73           
========================================
+ Hits        151496   151506   +10     
+ Misses       36902    36901    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for empty types is not yet implemented in incremental smt2 decision procedure

1 participant