Skip to content

SMT2 Incremental: Implement push/pop interface#8908

Draft
tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig:fix-8073-smt2-incr-push-pop
Draft

SMT2 Incremental: Implement push/pop interface#8908
tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig:fix-8073-smt2-incr-push-pop

Conversation

@tautschnig
Copy link
Copy Markdown
Collaborator

Replace UNIMPLEMENTED_FEATURE stubs in push(), push(assumptions), and pop() with working implementations that send SMT2 push/pop commands to the solver process.

  • push() sends smt_push_commandt{1} and increments context counter
  • pop() sends smt_pop_commandt{1} and decrements context counter, with PRECONDITION guard against popping from empty stack
  • push(assumptions) calls push() then set_to for each assumption
  • Add unit tests covering all three methods
  • Remove no-new-smt tag from fault_localization-stop_on_fail1 test

Fixes: #8073

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Replace UNIMPLEMENTED_FEATURE stubs in push(), push(assumptions), and
pop() with working implementations that send SMT2 push/pop commands
to the solver process.

- push() sends smt_push_commandt{1} and increments context counter
- pop() sends smt_pop_commandt{1} and decrements context counter,
  with PRECONDITION guard against popping from empty stack
- push(assumptions) calls push() then set_to for each assumption
- Add unit tests covering all three methods
- Remove no-new-smt tag from fault_localization-stop_on_fail1 test

Fixes: diffblue#8073
@tautschnig tautschnig self-assigned this Mar 28, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.42%. Comparing base (0170409) to head (c7145ba).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8908      +/-   ##
===========================================
+ Coverage    80.41%   80.42%   +0.01%     
===========================================
  Files         1703     1703              
  Lines       188398   188416      +18     
  Branches        73       73              
===========================================
+ Hits        151496   151535      +39     
+ Misses       36902    36881      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for the internal push/pop interface is unimplemented in incremental smt2 decision procedure

1 participant