SMT2 Incremental: Implement push/pop interface#8908
Draft
tautschnig wants to merge 1 commit intodiffblue:developfrom
Draft
SMT2 Incremental: Implement push/pop interface#8908tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
Replace UNIMPLEMENTED_FEATURE stubs in push(), push(assumptions), and
pop() with working implementations that send SMT2 push/pop commands
to the solver process.
- push() sends smt_push_commandt{1} and increments context counter
- pop() sends smt_pop_commandt{1} and decrements context counter,
with PRECONDITION guard against popping from empty stack
- push(assumptions) calls push() then set_to for each assumption
- Add unit tests covering all three methods
- Remove no-new-smt tag from fault_localization-stop_on_fail1 test
Fixes: diffblue#8073
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8908 +/- ##
===========================================
+ Coverage 80.41% 80.42% +0.01%
===========================================
Files 1703 1703
Lines 188398 188416 +18
Branches 73 73
===========================================
+ Hits 151496 151535 +39
+ Misses 36902 36881 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace UNIMPLEMENTED_FEATURE stubs in push(), push(assumptions), and pop() with working implementations that send SMT2 push/pop commands to the solver process.
Fixes: #8073