SMT2 Incremental: Resolve duplicate and missing declarations#8909
Draft
tautschnig wants to merge 1 commit intodiffblue:developfrom
Draft
SMT2 Incremental: Resolve duplicate and missing declarations#8909tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
Guard send_function_definition against duplicate declare-fun commands by checking identifier_table before sending. Guard define_index_identifiers against duplicate define-fun commands by checking expression_identifiers before defining. Ensure array element dependencies are declared before assertions by calling define_dependent_functions on elements in initialize_array_elements for both array_exprt and array_of_exprt. Remove no-new-smt tag from byte_extract1, Initialization6, and Pointer_byte_extract4 regression tests that now pass with the fix. Fixes: diffblue#8072
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8909 +/- ##
========================================
Coverage 80.41% 80.41%
========================================
Files 1703 1703
Lines 188398 188405 +7
Branches 73 73
========================================
+ Hits 151496 151509 +13
+ Misses 36902 36896 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard send_function_definition against duplicate declare-fun commands by checking identifier_table before sending. Guard define_index_identifiers against duplicate define-fun commands by checking expression_identifiers before defining. Ensure array element dependencies are declared before assertions by calling define_dependent_functions on elements in initialize_array_elements for both array_exprt and array_of_exprt.
Remove no-new-smt tag from byte_extract1, Initialization6, and Pointer_byte_extract4 regression tests that now pass with the fix.
Fixes: #8072