SMT2 Incremental: support array-to-array typecasts#8911
Draft
tautschnig wants to merge 1 commit intodiffblue:developfrom
Draft
SMT2 Incremental: support array-to-array typecasts#8911tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
Add handling for typecast expressions between two array types in the incremental SMT2 decision procedure. This is needed for SIMD operations (e.g. regression/cbmc/SIMD1) where arrays are reinterpreted with different element sizes. Changes: - gather_dependent_expressions: detect typecast_exprt where both source and target types are array_typet, adding them as dependent expressions - define_array_typecast_function: new method that creates an SMT array function for the target type and asserts element-by-element constraints using concatenation (widening) or extraction (narrowing) - define_dependent_functions: add branch to call the new method - convert_expr_to_smt.cpp: add UNHANDLED_CASE sentinel for array-to-array typecast (the expression is pre-substituted by the decision procedure) - Unit test for the UNHANDLED_CASE and sort conversion - Remove no-new-smt tag from SIMD1 regression test Fixes: diffblue#8075
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add handling for typecast expressions between two array types in the incremental SMT2 decision procedure. This is needed for SIMD operations (e.g. regression/cbmc/SIMD1) where arrays are reinterpreted with different element sizes.
Changes:
Fixes: #8075