Skip to content

Implement quantifier support for incremental SMT2 decision procedure#8921

Draft
tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig:fix-8053-smt2-incr-quantifiers
Draft

Implement quantifier support for incremental SMT2 decision procedure#8921
tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig:fix-8053-smt2-incr-quantifiers

Conversation

@tautschnig
Copy link
Copy Markdown
Collaborator

  • Add proper conversion of forall_exprt and exists_exprt to SMT terms
  • Implement special handling for quantifier expressions in expression traversal
  • Fix tuple conversion INVARIANT violations by processing only quantifier bodies
  • Extract and handle bound variables correctly in SMT conversion
  • Skip code address expressions to avoid unnecessary conversions

Fixes: #8053

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

- Add proper conversion of forall_exprt and exists_exprt to SMT terms
- Implement special handling for quantifier expressions in expression traversal
- Fix tuple conversion INVARIANT violations by processing only quantifier bodies
- Extract and handle bound variables correctly in SMT conversion
- Skip code address expressions to avoid unnecessary conversions

Fixes: diffblue#8053
@tautschnig tautschnig self-assigned this Mar 28, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

❌ Patch coverage is 34.61538% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.40%. Comparing base (0170409) to head (abbb3c2).

Files with missing lines Patch % Lines
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp 30.00% 14 Missing ⚠️
...ncremental/smt2_incremental_decision_procedure.cpp 50.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8921      +/-   ##
===========================================
- Coverage    80.41%   80.40%   -0.01%     
===========================================
  Files         1703     1703              
  Lines       188398   188418      +20     
  Branches        73       73              
===========================================
+ Hits        151496   151504       +8     
- Misses       36902    36914      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quantifier support is not yet implemented for incremental smt2 decision procedure

1 participant