feat: add verify command and dependency preflight check#788
Closed
caoergou wants to merge 2 commits intodifferent-ai:devfrom
Closed
feat: add verify command and dependency preflight check#788caoergou wants to merge 2 commits intodifferent-ai:devfrom
caoergou wants to merge 2 commits intodifferent-ai:devfrom
Conversation
PR different-ai#776 introduced a JavaScript module (local-file-path.impl.js) without a corresponding type declaration, causing TS7016 error when running typecheck with strict settings. This adds the missing .d.ts file to provide type information for the normalizeLocalFilePath function.
…#708) - Add `pnpm preflight` to validate development environment - Required: Node.js 18+, pnpm 10.27.0+, Bun 1.3.9+ - Optional: cargo, opencode, tauri (for desktop development) - Version validation with clear error messages - CI/NO_COLOR environment support - Add `pnpm verify` as canonical pre-PR validation - Runs: preflight → typecheck → test:e2e - Aligns local checks with CI workflow - Update CI to include typecheck step - Ensures type errors are caught in CI - Update documentation - README.md: Add preflight and verify commands - AGENTS.md: Add PR expectations section
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@caoergou is attempting to deploy a commit to the 0 Finance Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Collaborator
|
Appreciate the effort here, but not sure we want to change the workflow tests systems or introduce preflight |
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm preflightto validate development environment (Node.js 18+, pnpm 10.27.0+, Bun 1.3.9+)pnpm verifyas canonical pre-PR validation commandWhy
Closes #708
During implementation, discovered that PR #776 introduced a TypeScript module without a corresponding type declaration, causing
pnpm typecheckto fail. This PR includes the fix.Test Plan
pnpm preflightpasses with all required toolspnpm typecheckpasses (TS7016 fixed)pnpm verifyruns complete validation pipeline