Skip to content

fix(desktop): include stage diagnostics in sandbox probe timeout errors#797

Merged
OmarMcAdam merged 1 commit intodifferent-ai:devfrom
SergioChan:fix-sandbox-probe-timeout-diagnostics
Mar 11, 2026
Merged

fix(desktop): include stage diagnostics in sandbox probe timeout errors#797
OmarMcAdam merged 1 commit intodifferent-ai:devfrom
SergioChan:fix-sandbox-probe-timeout-diagnostics

Conversation

@SergioChan
Copy link
Contributor

Summary

  • add format_sandbox_start_timeout_error(...) to produce deterministic timeout diagnostics for detached sandbox startup
  • include probe stage context directly in timeout failures (stage, elapsed ms, target url, last health error, container state, optional container inspect error)
  • cover the formatter with a focused unit test so the diagnostic contract stays stable

Why

Issue

Scope

  • packages/desktop/src-tauri/src/commands/orchestrator.rs
  • timeout-message formatting only; no behavior change to startup sequence or timeout thresholds

Out of scope

  • changing sandbox startup timing/retry policy
  • adding cross-process log capture plumbing to the detached host launcher

Testing

Ran

  • git diff --check HEAD~1..HEAD

Result

  • pass/fail: pass
  • if fail, exact files/errors: N/A

CI status

  • pass: not run locally
  • code-related failures: N/A
  • external/env/auth blockers: rust toolchain unavailable in this environment (cargo: command not found), so Rust unit tests could not be executed locally

Manual verification

  1. trigger sandbox probe with Docker preflight healthy but OpenWork health endpoint unreachable
  2. inspect returned error string from sandbox_debug_probe
  3. confirm timeout error now includes stage=openwork.healthcheck plus elapsed/url/last_error/container diagnostics

Evidence

  • N/A (runtime diagnostics change)

Risk

  • low: string formatting/path for timeout errors only

Rollback

  • revert commit e0a59c57 from this branch

@vercel
Copy link

vercel bot commented Mar 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openwork-software Ready Ready Preview, Comment Mar 8, 2026 3:59pm

@vercel
Copy link

vercel bot commented Mar 8, 2026

@SergioChan is attempting to deploy a commit to the 0 Finance Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

The following comment was made by an LLM, it may be inaccurate:

@OmarMcAdam OmarMcAdam merged commit a8ad72d into different-ai:dev Mar 11, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Sandbox probe fails with localhost health connection refused even when Docker doctor is healthy

2 participants