Pull #18820: Consolidate `CI` to fix `error-prone` `rewrite` and `spotbugs` execution #2825 #2847

Pankraz76 · 2026-02-01T11:57:25Z

No description provided.

Pankraz76 · 2026-02-01T11:58:24Z

.github/workflows/ci.yml

-      - name: assemble testClasses
-        run: ./gradlew assemble testClasses
+      - name: Spotbugs 🐞
+        run: ./gradlew spotbugsMain


here seems to be no gate keeper, calling this goal:

https://github.com/search?q=repo%3Adiffplug%2Fspotless%20spotbugsMain&type=code

Pankraz76 · 2026-02-01T11:59:03Z

.github/workflows/ci.yml

+      - name: Error Prone 🚧️
+        run: ./gradlew assemble -DERROR_PRONE=true
+      - name: OpenRewrite ☑️ # 4m 55s
+        run: ./gradlew rewriteDryRun


might extract this job to CRON job to make it optional as requested.

Pankraz76 · 2026-02-01T11:59:14Z

gradle/wrapper/gradle-wrapper.properties

 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionSha256Sum=0d585f69da091fc5b2beced877feab55a3064d43b8a1d46aeb07996b0915e0e0
-distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.0-bin.zip


rewrite update.

Pankraz76 · 2026-02-01T11:59:32Z

plugin-gradle/src/main/java/com/diffplug/gradle/spotless/FormatExtension.java

 		return spotless.getRegisterDependenciesTask().getTaskService().get().provisionerFor(spotless);
 	}

-	protected final com.diffplug.spotless.extra.P2Provisioner p2Provisioner() {


prone stuff but rewrite could cover this as well of course.

Pankraz76 · 2026-02-01T12:01:34Z

PULL_REQUEST_TEMPLATE.md


 This makes it easier for the maintainers to quickly release your changes :)
+
+## Check and format code


this seems to be the critical point left behind last time. Communicating properly will help everybody to follow up as its done all over the other projects giving the convention and standard we also following.

This will make sure its better digested by the community.

Pankraz76 · 2026-02-01T12:04:43Z

prone example, should be simple to follow (c&p or allow patching later on) normally we have strong foundation no need to make invasive change.

* What went wrong:
Execution failed for task ':plugin-gradle:compileTestJava'.
> Compilation failed; see the compiler output below.
  /home/runner/work/spotless/spotless/plugin-gradle/src/test/java/com/diffplug/gradle/spotless/GradleIntegrationHarness.java:92: error: [UnnecessarilyFullyQualified] This fully qualified name is unambiguous to the compiler if imported.
40 actionable tasks: 7 executed, 33 up-to-date
  		return org.gradle.api.internal.provider.Providers.of(value);

  		                                       ^
      (see https://errorprone.info/bugpattern/UnnecessarilyFullyQualified)
    Did you mean 'return Providers.of(value);'?
  1 error

* Try:
> Check your code and dependencies to fix the compilation error(s)

Pankraz76 · 2026-02-01T12:12:09Z

CONTRIBUTING.md

+* Spotless ✨
+  * `./gradlew spotlessApply`
+* Spotbugs 🐞
+  * `./gradlew spotbugsMain`


good UX - simple to interact (clickable)

Pankraz76 · 2026-02-01T12:29:30Z

.github/workflows/ci.yml

+      - name: Error Prone 🚧️
+        run: ./gradlew assemble -Derror-prone=true
+      - name: OpenRewrite ☑️ # 4m 55s
+        run: ./gradlew rewriteDryRun -DfailOnDryRunResults=false


this will let corrupt code pass which is kind of the same having it optional, so its not applied at the end result. This makes it easy to activate once the community has adapted.

its just the same like spotless the the mechanism is nothing new at all. Let some time pass to see how its possible to integrate and then activate.

it takes some time yes 5 mins. the rewrite guys have 2 jobs because there war a hard 15 mins limit so in comparison it seems fast and acceptable.

whole build takes 8 mins with test so its in the range.

Pull #18795: Dedicate rewrite recipes checkstyle/checkstyle#18795

Pankraz76 · 2026-02-01T14:35:03Z

time is acceptable only double of the compile time:

Pankraz76 · 2026-02-01T15:22:07Z

lib/src/main/java/com/diffplug/spotless/java/ImportSorterImpl.java

 		}
 		// if there is \n on the end, remove it
-		if (!template.isEmpty() && ImportSorter.N.equals(template.get(template.size() - 1))) {
-			template.remove(template.size() - 1);


this is clearly more complicated and therefore error-prone.

…tbugs` execution diffplug#2825

Pankraz76 · 2026-02-01T16:02:47Z

kindly request your call on this, thanks.

@jbduncan @nedtwigg @Plunts

fyi @romani

Pankraz76 commented Feb 1, 2026

View reviewed changes

Pankraz76 force-pushed the rewriteDryRun branch 2 times, most recently from 86f0156 to de1215b Compare February 1, 2026 12:10

Pankraz76 commented Feb 1, 2026

View reviewed changes

Pankraz76 force-pushed the rewriteDryRun branch 2 times, most recently from b9059ab to 3544119 Compare February 1, 2026 12:26

Pankraz76 commented Feb 1, 2026

View reviewed changes

Pankraz76 changed the title ~~Pull #18820: Consolidate CI fix error-prone rewrite and spotbugs execution #2825~~ Pull #18820: Consolidate CI to fix error-prone rewrite and spotbugs execution #2825 Feb 1, 2026

Pankraz76 force-pushed the rewriteDryRun branch from 3544119 to f8d95f6 Compare February 1, 2026 15:20

Pankraz76 commented Feb 1, 2026

View reviewed changes

Pankraz76 force-pushed the rewriteDryRun branch 4 times, most recently from 4379ec6 to b973e5c Compare February 1, 2026 15:49

Pull #18820: Consolidate CI to fix error-prone rewrite and `spo…

7ae6c8a

…tbugs` execution diffplug#2825

Pankraz76 force-pushed the rewriteDryRun branch from b973e5c to 7ae6c8a Compare February 1, 2026 15:53

Pankraz76 marked this pull request as ready for review February 1, 2026 16:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pull #18820: Consolidate `CI` to fix `error-prone` `rewrite` and `spotbugs` execution #2825 #2847

Pull #18820: Consolidate `CI` to fix `error-prone` `rewrite` and `spotbugs` execution #2825 #2847

Pankraz76 commented Feb 1, 2026 •

edited

Loading

Uh oh!

Pankraz76 Feb 1, 2026

Uh oh!

Pankraz76 Feb 1, 2026

Uh oh!

Pankraz76 Feb 1, 2026

Uh oh!

Pankraz76 Feb 1, 2026

Uh oh!

Pankraz76 Feb 1, 2026

Uh oh!

Pankraz76 commented Feb 1, 2026

Uh oh!

Pankraz76 Feb 1, 2026

Uh oh!

Pankraz76 Feb 1, 2026

Uh oh!

Pankraz76 commented Feb 1, 2026

Uh oh!

Pankraz76 Feb 1, 2026

Uh oh!

Pankraz76 commented Feb 1, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant


		This makes it easier for the maintainers to quickly release your changes :)

		## Check and format code

Pull #18820: Consolidate CI to fix error-prone rewrite and spotbugs execution #2825 #2847

Are you sure you want to change the base?

Pull #18820: Consolidate CI to fix error-prone rewrite and spotbugs execution #2825 #2847

Conversation

Pankraz76 commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pankraz76 commented Feb 1, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pankraz76 commented Feb 1, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pankraz76 commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Pull #18820: Consolidate `CI` to fix `error-prone` `rewrite` and `spotbugs` execution #2825 #2847

Pull #18820: Consolidate `CI` to fix `error-prone` `rewrite` and `spotbugs` execution #2825 #2847

Pankraz76 commented Feb 1, 2026 •

edited

Loading

Pankraz76 commented Feb 1, 2026 •

edited

Loading