Skip to content

feat: skip update_stretch() when rho = 0#179

Closed
john-halloran wants to merge 3 commits intodiffpy:john-developmentfrom
john-halloran:reduce-to-nmf
Closed

feat: skip update_stretch() when rho = 0#179
john-halloran wants to merge 3 commits intodiffpy:john-developmentfrom
john-halloran:reduce-to-nmf

Conversation

@john-halloran
Copy link

The program now acts like regular NMF when rho = 0 and I've confirmed the results match ordinary sckit-learn.decomposition.NMF. Should be handy for comparison.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (john-development@d18b930). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             john-development     #179   +/-   ##
===================================================
  Coverage                    ?   77.50%           
===================================================
  Files                       ?        3           
  Lines                       ?       40           
  Branches                    ?        0           
===================================================
  Hits                        ?       31           
  Misses                      ?        9           
  Partials                    ?        0           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@john-halloran
Copy link
Author

I'm confused why it thinks the line length is >79 when locally, it is not and my black checks are passing okay. Could it be reformatting or pulling from a different version?

@sbillinge
Copy link
Contributor

it's likely uncorrected code in the main branch. pre-commit locally by default just runs on the files that have been modified, but in ci it runs --all-files. You will have to do that locally to find the others to fix probably.

I am not sure that this is what is happening but probably.

@john-halloran john-halloran deleted the reduce-to-nmf branch February 7, 2026 02:02
@john-halloran
Copy link
Author

Somehow this got dirtied up so I will redo it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants