Skip to content

deprecate: deprecate setProfile#144

Merged
sbillinge merged 5 commits intodiffpy:mainfrom
cadenmyers13:dep-setprofile
Feb 6, 2026
Merged

deprecate: deprecate setProfile#144
sbillinge merged 5 commits intodiffpy:mainfrom
cadenmyers13:dep-setprofile

Conversation

@cadenmyers13
Copy link
Contributor

@cadenmyers13 cadenmyers13 commented Feb 3, 2026

First shot test following my instructions. everything seemed to work as desired. This will fail until diffpy.utils 3.7.0 is released

@sbillinge
Copy link
Contributor

Looks great! Let's merge when tests pass.

@sbillinge
Copy link
Contributor

@cadenmyers13 this is successfully loading _deprecator now, but there is a bug in this PR because we changed the name of deprecation_message to build_deprecation_message.

@cadenmyers13
Copy link
Contributor Author

@sbillinge ah nice catch, thanks. this is good now

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.36%. Comparing base (47d6dc6) to head (fe502e2).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_sas.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   69.36%   69.36%           
=======================================
  Files          25       25           
  Lines        3457     3457           
=======================================
  Hits         2398     2398           
  Misses       1059     1059           
Files with missing lines Coverage Δ
tests/conftest.py 91.48% <100.00%> (ø)
tests/test_contribution.py 99.51% <100.00%> (ø)
tests/test_fitrecipe.py 99.76% <100.00%> (ø)
tests/test_profilegenerator.py 97.95% <100.00%> (ø)
tests/test_sas.py 15.78% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge sbillinge merged commit 8db7cc6 into diffpy:main Feb 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants