Expand duplicate_geometry_check expectation#520
Open
sianteesdale wants to merge 3 commits intomainfrom
Open
Conversation
pooleycodes
approved these changes
Apr 10, 2026
Author
|
Waiting to merge this PR until Monday, to avoid any undue effects over the weekend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Currently, the duplicate_geometry_check expectation raises entities that have either 100% overlap (
complete_match) or one geography that has >95% overlap (single_match). This results in smaller overlaps to slip through the system due to them not being reported through these tests.This PR allows for all overlaps to be returned through the
any_matchlabel. This will then be fed into our reporting tasks so we can monitor any overlaps, and ask LPAs to edit their data.There are no increases to timings by adding any_match into the script - the script already calculates all overlaps, it just previously discarded those that didn't match the conditions for
single_matchorcomplete_match.Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Locally testing the logic resulted in 2,534 rows being returned when testing on conservation-area data only - an increase of 2,208 rows from previously. Timings remained the same at approximately ~129 seconds.
Hard to QA without Docker container being installed - happy to share a test script Claude wrote for me to test (as I don't have Docker on my Mac!).
Added/updated tests?
have not been included