Skip to content

Fix expansion with @base#248

Open
anatoly-scherbakov wants to merge 3 commits intomasterfrom
fix-expand-base
Open

Fix expansion with @base#248
anatoly-scherbakov wants to merge 3 commits intomasterfrom
fix-expand-base

Conversation

@anatoly-scherbakov
Copy link
Copy Markdown
Collaborator

  • Guard active @base use in _expand_iri when base is not None
  • Add regression test for @base vs property term expansion

@anatoly-scherbakov anatoly-scherbakov self-assigned this Apr 10, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

@davidlehn
Copy link
Copy Markdown
Member

  • Why are those dev libs now needed? Did the github testing systems change behavior?
  • If that test is not in the main JSON-LD API test suite, please add it there immediately. The WG needs to agree on the behavior (I assume they will in this case) and have tests to ensure all implementations interoperate. That also removes the need to have the test duplicated here.
  • If the above can not be done now for some reason, then before merging this, please add tracking issues in the json-ld api repo and here to add the test case and clean it up here.

@anatoly-scherbakov
Copy link
Copy Markdown
Collaborator Author

@davidlehn, thanks for the review!

  • Updated the test comment as suggested 👍
  • libxml2-dev / libxslt1-dev are needed when CI builds lxml from source on PyPy (no wheel for that combo). I did not check how it ran before, it failed for me, and I fixed it.

This bug is a very recent regression. I haven't found a test in the suite that would cover it. Which explains why the bug could appear.

PR in json-ld-api added: w3c/json-ld-api#686 — but, it is unclear when that can be merged. For that reason, I propose we merge this PR. I do not consider a redundant test a problem, provided that the test is spec compliant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants