Open
Conversation
also added `dyn` to fix errors where necessary
Member
|
Hi, thank you for this PR! This is unfortunately not a good time as my comment on dimforge/ncollide#297 (comment) applies to nphysics too where massive work is also happening in the ccd branch. Sorry I did not mention nphysics in my aforementioned comment. I'll keep this PR open for now though, just to remember that needs to be done at some point after the work on the ccd branch is complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I noticed there doesn't seem to be much work going on here at the moment and figured this might be a good time to make this PR since the likelyhood of massive quantities of merge conflicts is severely reduced. If this is not the right time then feel free to close this PR and schedule these changes for another time, all changes were made completely automated by running
cargo fixafter adding#![deny(bare_trait_objects)]to lib.rs.dimforge/ncollide#297 provides a bit of background for the reasons why it's preferable to enforce
dynin front of every trait-object but in short it enhances their visibility by distinguishing them from structs.