i18n(pricing): add missing multi-provider badge key#877
i18n(pricing): add missing multi-provider badge key#877NieiR wants to merge 1 commit intoding113:devfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor, isolated defect by introducing a missing translation key for "multi-provider" badges within the pricing settings. This change specifically targets Japanese, Russian, and Traditional Chinese localization files, ensuring that the UI displays correctly in these languages. The PR was intentionally kept small to facilitate quick review and deployment, separating it from larger, more complex pricing or proxy-related changes. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 Walkthrough概述在三个多语言JSON消息文件中的 变更
代码审查工作量估计🎯 2 (Simple) | ⏱️ ~8 分钟 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request adds the missing prices.badges.multi translation key to the Japanese, Russian, and Traditional Chinese localization files. The changes are correct and consistent with the existing structure of the i18n files. The new keys will enable the 'multi-provider' badge to be displayed in the respective languages, fixing the defect described. The changes are well-isolated and address the issue effectively.
Note: Security Review has been skipped due to the limited scope of the PR.
There was a problem hiding this comment.
Code Review Summary
This PR adds the missing prices.badges.multi i18n translation key to three locale files (ja, ru, zh-TW). The changes are minimal, well-scoped, and correctly fix the translation gap identified by the guard test.
PR Size: XS
- Lines changed: 9 (6 additions, 3 modifications for trailing commas)
- Files changed: 3
Translation Verification
| Locale | Key | Translation | Accuracy |
|---|---|---|---|
| en (ref) | badges.multi | "Multi" | Source |
| zh-CN (canonical) | badges.multi | "多供应商" | Source |
| ja | badges.multi | "複数プロバイダー" | Correct - "multiple providers" |
| ru | badges.multi | "Несколько провайдеров" | Correct - "several providers" |
| zh-TW | badges.multi | "多供應商" | Correct - "multiple providers" (Traditional) |
Test Verification
- Guard test (
tests/unit/i18n/settings-split-guards.test.ts) passes on PR branch - All 5 locales now have matching key sets with correct leaf types
Issues Found
| Category | Critical | High | Medium | Low |
|---|---|---|---|---|
| Logic/Bugs | 0 | 0 | 0 | 0 |
| Security | 0 | 0 | 0 | 0 |
| Error Handling | 0 | 0 | 0 | 0 |
| Types | 0 | 0 | 0 | 0 |
| Comments/Docs | 0 | 0 | 0 | 0 |
| Tests | 0 | 0 | 0 | 0 |
| Simplification | 0 | 0 | 0 | 0 |
Review Coverage
- Logic and correctness - Clean
- Security (OWASP Top 10) - N/A (JSON data)
- Error handling - N/A (JSON data)
- Type safety - N/A (JSON data)
- Documentation accuracy - N/A (JSON data)
- Test coverage - Guard test validates key consistency
- Code clarity - Good
Automated review by Claude AI
|
Closing this PR because the current CI failures need to be recovered in one baseline-fix PR first. I have resubmitted the blocking build/test fixes as a new standalone PR so the CI baseline can be restored before smaller follow-up changes are reviewed separately. |
Summary
Adds missing
prices.badges.multitranslation key to Japanese (ja), Russian (ru), and Traditional Chinese (zh-TW) locale files.Problem
PR #873 introduced the multi-provider badge for pricing UI, but the translation key
prices.badges.multiwas only added to English, Simplified Chinese (zh-CN), and dashboard translations - not to the three settings price locale files.This causes the multi-provider badge to render as a missing translation key (e.g., "prices.badges.multi") instead of localized text in Japanese, Russian, and Traditional Chinese interfaces.
Related PR:
Solution
Add the missing
prices.badges.multikey to:messages/ja/settings/prices.json- "複数プロバイダー" (Multiple Providers)messages/ru/settings/prices.json- "Несколько провайдеров" (Multiple Providers)messages/zh-TW/settings/prices.json- "多供應商" (Multiple Vendors)Changes
Core Changes
prices.badges.multikey to 3 locale filesTesting
bunx vitest run tests/unit/i18n/settings-split-guards.test.ts(if exists)zh-TW,ja, orruand verify the multi-provider badge renders as localized textChecklist
Description enhanced by Claude AI