Skip to content

i18n(pricing): add missing multi-provider badge key#877

Closed
NieiR wants to merge 1 commit intoding113:devfrom
NieiR:split/pricing-i18n-multi-badge
Closed

i18n(pricing): add missing multi-provider badge key#877
NieiR wants to merge 1 commit intoding113:devfrom
NieiR:split/pricing-i18n-multi-badge

Conversation

@NieiR
Copy link
Contributor

@NieiR NieiR commented Mar 7, 2026

Summary

Adds missing prices.badges.multi translation key to Japanese (ja), Russian (ru), and Traditional Chinese (zh-TW) locale files.

Problem

PR #873 introduced the multi-provider badge for pricing UI, but the translation key prices.badges.multi was only added to English, Simplified Chinese (zh-CN), and dashboard translations - not to the three settings price locale files.

This causes the multi-provider badge to render as a missing translation key (e.g., "prices.badges.multi") instead of localized text in Japanese, Russian, and Traditional Chinese interfaces.

Related PR:

Solution

Add the missing prices.badges.multi key to:

  • messages/ja/settings/prices.json - "複数プロバイダー" (Multiple Providers)
  • messages/ru/settings/prices.json - "Несколько провайдеров" (Multiple Providers)
  • messages/zh-TW/settings/prices.json - "多供應商" (Multiple Vendors)

Changes

Core Changes

  • Added prices.badges.multi key to 3 locale files

Testing

  • Run bunx vitest run tests/unit/i18n/settings-split-guards.test.ts (if exists)
  • Open the Prices settings page in zh-TW, ja, or ru and verify the multi-provider badge renders as localized text

Checklist

  • Code follows project conventions
  • Self-review completed
  • Tests pass locally (if applicable)

Description enhanced by Claude AI

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor, isolated defect by introducing a missing translation key for "multi-provider" badges within the pricing settings. This change specifically targets Japanese, Russian, and Traditional Chinese localization files, ensuring that the UI displays correctly in these languages. The PR was intentionally kept small to facilitate quick review and deployment, separating it from larger, more complex pricing or proxy-related changes.

Highlights

  • Missing Translation Key: Added the prices.badges.multi translation key to Japanese, Russian, and Traditional Chinese localization files for pricing settings, ensuring correct display of multi-provider badges.
Changelog
  • messages/ja/settings/prices.json
    • Added the prices.badges.multi key with the Japanese translation "複数プロバイダー".
  • messages/ru/settings/prices.json
    • Added the prices.badges.multi key with the Russian translation "Несколько провайдеров".
  • messages/zh-TW/settings/prices.json
    • Added the prices.badges.multi key with the Traditional Chinese translation "多供應商".
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Mar 7, 2026

📝 Walkthrough

概述

在三个多语言JSON消息文件中的badges对象内添加了新的multi条目,用于表示多个提供商支持。每个文件使用相应语言的本地化文本。

变更

群组 / 文件 摘要
多语言徽章条目
messages/ja/settings/prices.json, messages/ru/settings/prices.json, messages/zh-TW/settings/prices.json
badges对象中添加新的"multi"字段,分别包含日文("複数プロバイダー")、俄文("Несколько провайдеров")和繁体中文("多供應商")的本地化文本。调整JSON语法,在相邻条目后添加逗号以保持有效格式。

代码审查工作量估计

🎯 2 (Simple) | ⏱️ ~8 分钟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed 拉取请求标题清晰地总结了主要变更:向多个区域设置文件添加缺失的多提供商徽章翻译键。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly describes the changes: adding missing translation keys for the multi-provider badge to three locale files (Japanese, Russian, and Traditional Chinese), with context about the related issue and testing instructions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the missing prices.badges.multi translation key to the Japanese, Russian, and Traditional Chinese localization files. The changes are correct and consistent with the existing structure of the i18n files. The new keys will enable the 'multi-provider' badge to be displayed in the respective languages, fixing the defect described. The changes are well-isolated and address the issue effectively.

Note: Security Review has been skipped due to the limited scope of the PR.

@github-actions github-actions bot added bug Something isn't working area:i18n size/XS Extra Small PR (< 50 lines) labels Mar 7, 2026
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

This PR adds the missing prices.badges.multi i18n translation key to three locale files (ja, ru, zh-TW). The changes are minimal, well-scoped, and correctly fix the translation gap identified by the guard test.

PR Size: XS

  • Lines changed: 9 (6 additions, 3 modifications for trailing commas)
  • Files changed: 3

Translation Verification

Locale Key Translation Accuracy
en (ref) badges.multi "Multi" Source
zh-CN (canonical) badges.multi "多供应商" Source
ja badges.multi "複数プロバイダー" Correct - "multiple providers"
ru badges.multi "Несколько провайдеров" Correct - "several providers"
zh-TW badges.multi "多供應商" Correct - "multiple providers" (Traditional)

Test Verification

  • Guard test (tests/unit/i18n/settings-split-guards.test.ts) passes on PR branch
  • All 5 locales now have matching key sets with correct leaf types

Issues Found

Category Critical High Medium Low
Logic/Bugs 0 0 0 0
Security 0 0 0 0
Error Handling 0 0 0 0
Types 0 0 0 0
Comments/Docs 0 0 0 0
Tests 0 0 0 0
Simplification 0 0 0 0

Review Coverage

  • Logic and correctness - Clean
  • Security (OWASP Top 10) - N/A (JSON data)
  • Error handling - N/A (JSON data)
  • Type safety - N/A (JSON data)
  • Documentation accuracy - N/A (JSON data)
  • Test coverage - Guard test validates key consistency
  • Code clarity - Good

Automated review by Claude AI

@NieiR
Copy link
Contributor Author

NieiR commented Mar 7, 2026

Closing this PR because the current CI failures need to be recovered in one baseline-fix PR first.

I have resubmitted the blocking build/test fixes as a new standalone PR so the CI baseline can be restored before smaller follow-up changes are reviewed separately.

@NieiR NieiR closed this Mar 7, 2026
@github-project-automation github-project-automation bot moved this from Backlog to Done in Claude Code Hub Roadmap Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n bug Something isn't working size/XS Extra Small PR (< 50 lines)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant