fix(ion-range): support @ionic/core >= 8.8.x knob class rename#15
Merged
fix(ion-range): support @ionic/core >= 8.8.x knob class rename#15
Conversation
@ionic/core 8.8.x renamed shadow-DOM knob classes from range-knob-a/range-knob-b to range-knob-handle-a/range-knob-handle-b. Use comma-separated CSS selectors to match both old and new class names, keeping @ionic/core 8.7.x support intact (no breaking change). Bumps version to 1.1.1 and devDependency to ^8.8.0.
…bility Ionic 8.8.x requires TypeScript 5+ (const type parameters in Stencil runtime types). Upgrades typescript to ^5.0.0, typedoc to ^0.28.0, ts-patch to ^3.0.0, and typescript-transform-paths to ^3.5.0. Relaxes internal generic constraints from HTMLStencilElement to Element to accommodate the autocorrect type change in HTMLIonInputElement 8.8.x.
distante
force-pushed
the
ssd/update-to-latest-ionic
branch
from
7a01501 to
0271f1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ionic/core 8.8.xrenamed the shadow-DOM knob CSS classes (range-knob-a→range-knob-handle-a,range-knob-b→range-knob-handle-b), causingionRangeCypress.moveToValue()to throw "No Handle was found in the shadow root" on any project that upgraded Ionic..range-knob-handle-a, .range-knob-handle.range-knob-a) so both8.7.xand8.8.xare supported — no breaking change, peerDependency floor unchanged (>= 8.7.0).get-from-supported-selector.spec.ts.^8.8.0to run the suite against the new Ionic version.Verification
All 16
range.spec.tstests and all 7get-from-supported-selector.spec.tstests pass against@ionic/core 8.8.x.